Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37211

Update mypy in RO packages

    XMLWordPrintable

Details

    Description

      Update mypy in packages Russell Owen is at least partially responsible for.

      Also update flake8 in .pre-commit-config.yaml (gitlab to github) and add isort support where missing. See https://confluence.lsstcorp.org/display/LTS/TSSW+pre-commit+hooks

      Attachments

        Activity

          No builds found.
          rowen Russell Owen created issue -
          rowen Russell Owen made changes -
          Field Original Value New Value
          Description Update mypy in packages Russell Owen is responsible for.

          Also update flake8 in .pre-commit-config.yaml (gitlab to github) and add isort support where missing.
          Update mypy in packages Russell Owen is responsible for.

          Also update flake8 in .pre-commit-config.yaml (gitlab to github) and add isort support where missing. See https://confluence.lsstcorp.org/display/LTS/TSSW+pre-commit+hooks
          rowen Russell Owen added a comment - - edited Another change I made was to remove {{args: [--config=pyproject.toml] }} from black, since we have no black configuration in pyproject.toml. This was present in a subset of the .pre-commit-config files. Now all of the files are identical in the following packages. Pull requests: https://github.com/lsst-ts/ts_authorize/pull/16 https://github.com/lsst-ts/ts_ess_common/pull/26 https://github.com/lsst-ts/ts_ess_common/pull/27 https://github.com/lsst-ts/ts_ess_controller/pull/33 https://github.com/lsst-ts/ts_ess_controller/pull/34 https://github.com/lsst-ts/ts_ess_csc/pull/74 https://github.com/lsst-ts/ts_ess_labjack/pull/18 https://github.com/lsst-ts/ts_MTAlignment/pull/17 https://github.com/lsst-ts/ts_salobj/pull/261 https://github.com/lsst-ts/ts_simactuators/pull/23 https://github.com/lsst-ts/ts_tcpip/pull/18 https://github.com/lsst-ts/ts_utils/pull/9
          rowen Russell Owen made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          rowen Russell Owen made changes -
          Description Update mypy in packages Russell Owen is responsible for.

          Also update flake8 in .pre-commit-config.yaml (gitlab to github) and add isort support where missing. See https://confluence.lsstcorp.org/display/LTS/TSSW+pre-commit+hooks
          Update mypy in packages Russell Owen is at least partially responsible for.

          Also update flake8 in .pre-commit-config.yaml (gitlab to github) and add isort support where missing. See https://confluence.lsstcorp.org/display/LTS/TSSW+pre-commit+hooks
          rowen Russell Owen made changes -
          Reviewers Wouter van Reeven [ wvreeven ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          rowen Russell Owen made changes -
          Story Points 2 1

          All PRs reviewed on GitHub.

          wvreeven Wouter van Reeven added a comment - All PRs reviewed on GitHub.
          wvreeven Wouter van Reeven made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          rowen Russell Owen added a comment - - edited

          Tagged:

          • ts_authorize v0.6.2
          • ts_ess_common v0.10.3
          • ts_ess_controller v0.7.4
          • ts_ess_csc v0.13.1
          • ts_ess_labjack v0.6.4
          • ts_MTAlignment v0.4.1
          • ts_salobj v7.2.1
          • ts_simactuators v2.2.7
          • ts_tcpip v0.4.3
          rowen Russell Owen added a comment - - edited Tagged: ts_authorize v0.6.2 ts_ess_common v0.10.3 ts_ess_controller v0.7.4 ts_ess_csc v0.13.1 ts_ess_labjack v0.6.4 ts_MTAlignment v0.4.1 ts_salobj v7.2.1 ts_simactuators v2.2.7 ts_tcpip v0.4.3
          rowen Russell Owen made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          rowen Russell Owen added a comment -

          ts_utils will not be tagged until another PR is merged.

          rowen Russell Owen added a comment - ts_utils will not be tagged until another PR is merged.

          People

            rowen Russell Owen
            rowen Russell Owen
            Wouter van Reeven
            Russell Owen, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.