Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37268

Pass correct FilterType to WEP configuration in ts_wep

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      Running the AOS loop `imgCloseLoop` allows to select `--filterType` . However, WEP configuration has `g` filter hard-coded : 

      generateDonutCatalogWcsTask:
      		 
      class: lsst.ts.wep.task.GenerateDonutCatalogWcsTask.GenerateDonutCatalogWcsTask
      		 
      # Here we specify the configurations for pointing that we added into the class
      		 
      # GenerateDonutCatalogWcsTaskConfig.
      		 
      config:
      		 
        filterName: 'g'
      		 
        referenceSelector.doMagLimit: True
      		 
        referenceSelector.magLimit.maximum: 15.90
      		 
        referenceSelector.magLimit.minimum: 8.74
      		 
        referenceSelector.magLimit.fluxField: 'g_flux'
      		 
        doDonutSelection: True
      		 
        donutSelector.fluxField: 'g_flux'

      This affects eg. proper magnitude limits used for source selection. This ticket is to address that issue and pass correct filter name to WEP configuration.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-37045 Check wavelength dependence in ts_aos

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            ksuberlak Krzysztof Suberlak created issue -
            ksuberlak Krzysztof Suberlak made changes -
            Field Original Value New Value
            Link This issue relates to DM-37045 [ DM-37045 ]
            ksuberlak Krzysztof Suberlak made changes -
            Story Points 34 4
            ksuberlak Krzysztof Suberlak made changes -
            Summary Pass correct FilteType to WEP configuration in ts_wep Pass correct FilterType to WEP configuration in ts_wep
            ksuberlak Krzysztof Suberlak made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            ksuberlak Krzysztof Suberlak added a comment -

            Th PR to ts_phosim that adds that functionality has been merged

            Show
            ksuberlak Krzysztof Suberlak added a comment - Th PR to ts_phosim that adds that functionality has been merged
            ksuberlak Krzysztof Suberlak made changes -
            Reviewers Te-Wei Tsai [ ttsai ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Reviewed in GitHub.

            Show
            ttsai Te-Wei Tsai added a comment - Reviewed in GitHub.
            ttsai Te-Wei Tsai made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            ksuberlak Krzysztof Suberlak made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              ksuberlak Krzysztof Suberlak
              Reporter:
              ksuberlak Krzysztof Suberlak
              Reviewers:
              Te-Wei Tsai
              Watchers:
              Krzysztof Suberlak, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.