# Review the MTDome Code

XMLWordPrintable

#### Details

• Story
• Status: Done
• Resolution: Done
• None
• 4
• TSSW Sprint - Dec 19 - Jan 02
• Telescope and Site
• No

#### Description

Review the EIE dome project: https://github.com/lsst-ts/dome_eie.

#### Attachments

1. HaschkeWeitnauerRitter08-OPT.pdf
277 kB
2. mtdome_software_review.docx
2.05 MB
3. Online_trajectory_planner_with_constraints_on_velo.pdf
1.33 MB
4. plot_pieces.py
1 kB
5. recommendation.docx
12 kB
6. Trajectory Planner Test.pptx
965 kB

#### Activity

Te-Wei Tsai added a comment -

Te-Wei Tsai added a comment - Papers reference by EIE: 1. Online_trajectory_planner_with_constraints_on_velo.pdf 2. HaschkeWeitnauerRitter08-OPT.pdf
Te-Wei Tsai added a comment - -

Checked the ts_mtdometrajectory. The SimpleAlgorithm is applied and the following part is interesting:
1. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L79-L83
2. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L117-L121

Basically, it only wants the MT Dome to do the point-to-point movement (velocity=0). If this is the case, we do not need a fancy trajectory planner that intends to deal with random position and velocity of targets.

Te-Wei Tsai added a comment - - Checked the ts_mtdometrajectory . The SimpleAlgorithm is applied and the following part is interesting: 1. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L79-L83 2. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L117-L121 Basically, it only wants the MT Dome to do the point-to-point movement ( velocity=0 ). If this is the case, we do not need a fancy trajectory planner that intends to deal with random position and velocity of targets.

This is an exhaustive and good review done by Te-Wei. Recommendations are included to improve the implementation done by EIE contractor, as well as suggestions on how to utilize proper software development tools. It would be necessary to enforce compliance of those recommendations on software delivery.

German Schumacher [X] (Inactive) added a comment - This is an exhaustive and good review done by Te-Wei. Recommendations are included to improve the implementation done by EIE contractor, as well as suggestions on how to utilize proper software development tools. It would be necessary to enforce compliance of those recommendations on software delivery.

Done with review.

German Schumacher [X] (Inactive) added a comment - Done with review.

#### People

Te-Wei Tsai
Te-Wei Tsai
German Schumacher [X] (Inactive), Wouter van Reeven
German Schumacher [X] (Inactive), Te-Wei Tsai, Wouter van Reeven