Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37329

Review the MTDome Code

    XMLWordPrintable

    Details

      Description

      Review the EIE dome project: https://github.com/lsst-ts/dome_eie.

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-37586 Review the MTDome Requirement Document

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-37708 Test the MTDome on Summit

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-38099 Review the Document of Dome Trajectory Planner

          • Done

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Please help to review the ticket based on the comment. Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the ticket based on the comment. Thanks!
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Papers reference by EIE:
            1. Online_trajectory_planner_with_constraints_on_velo.pdf
            2. HaschkeWeitnauerRitter08-OPT.pdf

            Show
            ttsai Te-Wei Tsai added a comment - Papers reference by EIE: 1. Online_trajectory_planner_with_constraints_on_velo.pdf 2. HaschkeWeitnauerRitter08-OPT.pdf
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            Checked the ts_mtdometrajectory. The SimpleAlgorithm is applied and the following part is interesting:
            1. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L79-L83
            2. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L117-L121

            Basically, it only wants the MT Dome to do the point-to-point movement (velocity=0). If this is the case, we do not need a fancy trajectory planner that intends to deal with random position and velocity of targets.

            Show
            ttsai Te-Wei Tsai added a comment - - edited Checked the ts_mtdometrajectory . The SimpleAlgorithm is applied and the following part is interesting: 1. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L79-L83 2. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L117-L121 Basically, it only wants the MT Dome to do the point-to-point movement ( velocity=0 ). If this is the case, we do not need a fancy trajectory planner that intends to deal with random position and velocity of targets.
            Hide
            Permalink
            gschumacher German Schumacher added a comment -

            This is an exhaustive and good review done by Te-Wei. Recommendations are included to improve the implementation done by EIE contractor, as well as suggestions on how to utilize proper software development tools. It would be necessary to enforce compliance of those recommendations on software delivery.

            Show
            gschumacher German Schumacher added a comment - This is an exhaustive and good review done by Te-Wei. Recommendations are included to improve the implementation done by EIE contractor, as well as suggestions on how to utilize proper software development tools. It would be necessary to enforce compliance of those recommendations on software delivery.
            Hide
            Permalink
            gschumacher German Schumacher added a comment -

            Done with review.

            Show
            gschumacher German Schumacher added a comment - Done with review.

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              German Schumacher, Wouter van Reeven
              Watchers:
              German Schumacher, Te-Wei Tsai, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.