Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37329

Review the MTDome Code

    XMLWordPrintable

Details

    Description

      Review the EIE dome project: https://github.com/lsst-ts/dome_eie.

      Attachments

        Issue Links

          Activity

            ttsai Te-Wei Tsai added a comment -

            Please help to review the ticket based on the comment. Thanks!

            ttsai Te-Wei Tsai added a comment - Please help to review the ticket based on the comment. Thanks!
            ttsai Te-Wei Tsai added a comment - Papers reference by EIE: 1. Online_trajectory_planner_with_constraints_on_velo.pdf 2. HaschkeWeitnauerRitter08-OPT.pdf
            ttsai Te-Wei Tsai added a comment - - edited

            Checked the ts_mtdometrajectory. The SimpleAlgorithm is applied and the following part is interesting:
            1. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L79-L83
            2. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L117-L121

            Basically, it only wants the MT Dome to do the point-to-point movement (velocity=0). If this is the case, we do not need a fancy trajectory planner that intends to deal with random position and velocity of targets.

            ttsai Te-Wei Tsai added a comment - - edited Checked the ts_mtdometrajectory . The SimpleAlgorithm is applied and the following part is interesting: 1. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L79-L83 2. https://github.com/lsst-ts/ts_mtdometrajectory/blob/develop/python/lsst/ts/mtdometrajectory/simple_algorithm.py#L117-L121 Basically, it only wants the MT Dome to do the point-to-point movement ( velocity=0 ). If this is the case, we do not need a fancy trajectory planner that intends to deal with random position and velocity of targets.

            This is an exhaustive and good review done by Te-Wei. Recommendations are included to improve the implementation done by EIE contractor, as well as suggestions on how to utilize proper software development tools. It would be necessary to enforce compliance of those recommendations on software delivery.

            gschumacher German Schumacher [X] (Inactive) added a comment - This is an exhaustive and good review done by Te-Wei. Recommendations are included to improve the implementation done by EIE contractor, as well as suggestions on how to utilize proper software development tools. It would be necessary to enforce compliance of those recommendations on software delivery.

            Done with review.

            gschumacher German Schumacher [X] (Inactive) added a comment - Done with review.

            People

              ttsai Te-Wei Tsai
              ttsai Te-Wei Tsai
              German Schumacher [X] (Inactive), Wouter van Reeven
              German Schumacher [X] (Inactive), Te-Wei Tsai, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.