Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37398

Timing of GenerateDonutDirectDetect in ts_wep

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      Inspect timing of the GenerateDonutDirectDetect algorithm. It currently runs slow (~few mins to detect donuts in an exposure), and we want to know which part makes it slow.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-37628 New task to upgrade generateDonutDirectDetect

          • Done
          mentioned in

          Page Loading...

          Page Loading...

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ksuberlak Krzysztof Suberlak added a comment -

            We find that the slow part is the adaptive thresholding used when `deblend` is chosen. It detects faint blends, but runs at ~2mins per exposure to make a binary image, compared to 0.2 sec when using the `centroid` option. This notebook documents the findings, and compares it to `afw.Detect` https://github.com/suberlak/AOS/blob/main/AOS_DM-37398_donutDirectDetect_timing.ipynb

            Show
            ksuberlak Krzysztof Suberlak added a comment - We find that the slow part is the adaptive thresholding used when `deblend` is chosen. It detects faint blends, but runs at ~2mins per exposure to make a binary image, compared to 0.2 sec when using the `centroid` option. This notebook documents the findings, and compares it to `afw.Detect` https://github.com/suberlak/AOS/blob/main/AOS_DM-37398_donutDirectDetect_timing.ipynb
            Hide
            Permalink
            jbkalmbach Bryce Kalmbach added a comment -

            Looks good. Thanks for finding that QuickFrameMeasurementTask. I think it will be useful to use as we upgrade this.

            Show
            jbkalmbach Bryce Kalmbach added a comment - Looks good. Thanks for finding that QuickFrameMeasurementTask. I think it will be useful to use as we upgrade this.

              People

              Assignee:
              ksuberlak Krzysztof Suberlak
              Reporter:
              ksuberlak Krzysztof Suberlak
              Reviewers:
              Bryce Kalmbach
              Watchers:
              Andrew Connolly, Bryce Kalmbach, Krzysztof Suberlak
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.