Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:
-
Story Points:4
-
Epic Link:
-
Sprint:TSSW Sprint - Jan 02 - Jan 16
-
Team:Telescope and Site
-
Urgent?:No
Description
Add a TCP/IP client class to ts_tcpip, modeled after OneClientServer and update at least one other package to use it, to prove that the API is useable.
Also improve OneClientServer:
- Allow async connected_callback functions and deprecate synchronous ones.
- Replace the optional family constructor argument with **kwargs (for more flexibility).
- Add optional monitor_connection_interval constructor argument, specify 0 to disable monitoring.
- Make the name constructor argument optional.
Also add constants LOCALHOST_IPV4 and LOCALHOST_IPV6 and deprecate LOCAL_HOST.
Attachments
Issue Links
Activity
Reviewed in GitHub.
Based on the review I decided to add wrapper methods for reading and writing. This avoids the need to check if the connection is open first, and in the case of read methods, avoids any need to notify the Client or OneClientServer if the other end has hung up – the read methods detect this internally. Please have another look, since these are rather extensive changes. And thank you for pushing for this. I think it does improve the API (though it adds a fair amount of code and more tests).
Reviewed again on github.
Based on reviewer comments I improved the documentation, then merged. Tagged ts_tcpip v1.0.0 and ts_hexrotcomm v0.31.0.
Pull requests:
Note that unit tests for the release versions of ts_mthexapod and ts_mtrotator pass (on my computer) using these two branches.