Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37479

Adapt the M2 Python Code to the Latest ts_tcpip Package

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • ts_main_telescope
    • 1
    • TSSW Sprint - Jan 16 - Jan 30
    • Telescope and Site
    • No

    Description

      Adapt the M2 Python code to the latest ts_tcpip package.

      Attachments

        Issue Links

          Activity

            ttsai Te-Wei Tsai added a comment - - edited

            I tried to refactor the TcpClient in ts_m2com to use the Client in ts_tcpip. However, the design of Client is that the user needs to instantiate the new instance after each connection (success or fail). I realized that I would need to change pretty much code in TcpClinet and others to adapt this.

            In addition, in the test, the code sometime just hang-ups or dies silently that I do not understand. Therefore, I would keep the update to use this new Client in the next time when it is needed. Otherwise, it is not very beneficial to use this Client at this moment.

            ttsai Te-Wei Tsai added a comment - - edited I tried to refactor the TcpClient in ts_m2com to use the Client in ts_tcpip . However, the design of Client is that the user needs to instantiate the new instance after each connection (success or fail). I realized that I would need to change pretty much code in TcpClinet and others to adapt this. In addition, in the test, the code sometime just hang-ups or dies silently that I do not understand. Therefore, I would keep the update to use this new Client in the next time when it is needed. Otherwise, it is not very beneficial to use this Client at this moment.
            ttsai Te-Wei Tsai added a comment - Please help to review the PRs: 1. https://github.com/lsst-ts/ts_m2com/pull/20 2. https://github.com/lsst-ts/ts_m2gui/pull/30 Thanks!

            PRs reviewed/approved in GH.

            tribeiro Tiago Ribeiro added a comment - PRs reviewed/approved in GH.

            People

              ttsai Te-Wei Tsai
              ttsai Te-Wei Tsai
              Tiago Ribeiro
              Te-Wei Tsai, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.