Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37501

Deprecate synchronous callbacks in salobj

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Jan 02 - Jan 16
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      We have decided to deprecate synchronous callbacks in salobj, including in ReadTopic, so that we can eventually simplify the code by assuming callbacks will be asynchronous.

      Test for synchronous callbacks and raise a deprecation warning.

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-37502 Require that callbacks from salobj be asynchronous

          • To Do
          mitigates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-37500 Increase verbosity in error messages during configuration unit tests

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-32120 [ 770392 ]
            Sprint TSSW Sprint - Jan 02 - Jan 16 [ 1211 ]
            rowen Russell Owen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Link This issue is triggering DM-37502 [ DM-37502 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Pull request: https://github.com/lsst-ts/ts_salobj/pull/264

            Show
            rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_salobj/pull/264
            rowen Russell Owen made changes -
            Link This issue mitigates DM-37500 [ DM-37500 ]
            rowen Russell Owen made changes -
            Reviewers Petr Kubanek [ pkubanek ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            pkubanek Petr Kubanek added a comment -

            Reviewed in GitHub.

            Show
            pkubanek Petr Kubanek added a comment - Reviewed in GitHub.
            pkubanek Petr Kubanek made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Merged to develop. I'm holding off release until the next build cycle since the change is so minor.

            Show
            rowen Russell Owen added a comment - Merged to develop. I'm holding off release until the next build cycle since the change is so minor.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Petr Kubanek
              Watchers:
              Petr Kubanek, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.