Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37628

New task to upgrade generateDonutDirectDetect

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      Currently auxTel data is  handled by default with generateDonutDirectDetect, which uses slow adaptive thresholding algorithm to detect donuts, not needing  the WCS information. this was done because at the time auxTel WCS was insufficient to use directly to select sources based on the reference catalog.  Quicker source detection codes (such as using the built-in https://github.com/lsst-ts/ts_wep/blob/develop/python/lsst/ts/wep/DonutDetector.py setting binaryChoice to centroid, or using the `afwDetect`) miss fainter blends with default settings, but could be used to obtain sufficient number of sources to solve for WCS. Given WCS, we can then update the donut catalog with https://github.com/lsst-ts/ts_wep/blob/develop/python/lsst/ts/wep/task/GenerateDonutCatalogWcsTask.py

      This ticket is to investigate what components this task would require to work properly with auxTel data.

        Attachments

          Issue Links

            Activity

            Hide
            ajc Andrew Connolly added a comment -

            Is this complete with Bryce's work?

            Show
            ajc Andrew Connolly added a comment - Is this complete with Bryce's work?
            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            This was already tested, and we found that the best way forward was to implement a similar method as with `QuickFrameMeasurementTask`, which ended up being morphed into an updated `generateDonutDirectDetect`

            Show
            ksuberlak Krzysztof Suberlak added a comment - This was already tested, and we found that the best way forward was to implement a similar method as with `QuickFrameMeasurementTask`, which ended up being morphed into an updated `generateDonutDirectDetect`
            Hide
            jbkalmbach Bryce Kalmbach added a comment -

            Do you have a timing comparison between the new one and the old one just to show the difference?

            Show
            jbkalmbach Bryce Kalmbach added a comment - Do you have a timing comparison between the new one and the old one just to show the difference?
            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            I've run timing for the old one here https://jira.lsstcorp.org/browse/DM-37398 , I'll make a new notebook showing the timing of the new one to compare the two

            Show
            ksuberlak Krzysztof Suberlak added a comment - I've run timing for the old one here https://jira.lsstcorp.org/browse/DM-37398  , I'll make a new notebook showing the timing of the new one to compare the two
            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            Timing of the updated `generateDonutDirectDetect` task with simulated `lsstCam` and real `auxTel` data https://github.com/suberlak/AOS/blob/main/AOS_DM-37628_update_generateDonutDirectDetect.ipynb Previously it took ~2min 10 sec per image, now source detection only takes ~1.2 sec per image, i.e. 100x speedup.

            Show
            ksuberlak Krzysztof Suberlak added a comment - Timing of the updated `generateDonutDirectDetect` task with simulated `lsstCam` and real `auxTel` data https://github.com/suberlak/AOS/blob/main/AOS_DM-37628_update_generateDonutDirectDetect.ipynb Previously it took ~2min 10 sec per image, now source detection only takes ~1.2 sec per image, i.e. 100x speedup.
            Hide
            jbkalmbach Bryce Kalmbach added a comment -

            New task added and new timing information shows speedup accomplished goals.

            Show
            jbkalmbach Bryce Kalmbach added a comment - New task added and new timing information shows speedup accomplished goals.

              People

              Assignee:
              ksuberlak Krzysztof Suberlak
              Reporter:
              ksuberlak Krzysztof Suberlak
              Reviewers:
              Bryce Kalmbach
              Watchers:
              Andrew Connolly, Bryce Kalmbach, Krzysztof Suberlak
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Due:
                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.