Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37705

Revisit file naming conventions for jar files created by SAL

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The normal maven convention for jar file naming, is that a pre-release of version 14.1.0_7.2.0 (for example) would be called: * sal_CCCamera_14.1.0_7.2.0-SNAPSHOT.jar

       
      (Note that the actual filename in nexus may be different, and may also include a timestamp, but this is hidden from the user who can just refer to the version as above). The naming convention we(SAL) are using is more like: * sal_CCCamera_14.0.0_7.2.0-2-gd8d2046fpre1236-SNAPSHOT

      Where the significant differences are: # This has "pre" in the name, while it is in fact "post" 14.0.0_7.2.0 (this is just confusing rather than an actual problem)

      1. This has the gd8d2046fpre1236 in the name (git hash?). The problem being that this hash appears to be different for each project (ATCamera, CCCamera, MTCamera) and changes with each build, which makes it almost impossible to use this as a dependency in some other project.

      In the past I could work around this, at least if I did a local build, by using a version argument to salgenerator, but this no longer seems to work: * salgenerator CCCaamera maven version=14.1.0_7.2.0-SNAPSHOT

      It does not complain, but it ignores the version. For a long time this has not been an issue, since we have just been using "released" versions of ts_xml which do not have these problems, but since we need to make progress on the main camera, I think we are no longer in the position of being able to wait for releases.

      Ideally the nightly builds would generate jar files which correspond to the maven naming conventions, and ideally salgenerator (if it will still exist after the switch to kafka) would allow the version # to be set.

        Attachments

          Issue Links

            Activity

            Hide
            rbovill Rob Bovill added a comment -

            SAL was updated to name the Jar files according to the requested format.

            PR reviewed and approved.

            Show
            rbovill Rob Bovill added a comment - SAL was updated to name the Jar files according to the requested format. PR reviewed and approved.

              People

              Assignee:
              dmills Dave Mills
              Reporter:
              tjohnson Tony Johnson
              Reviewers:
              Rob Bovill
              Watchers:
              Max Turri, Rob Bovill, Tony Johnson
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.