Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3789

Upgrade fftw to v3.3.4

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: fftw
    • Labels:
      None
    • Team:
      Architecture

      Description

      The current version of fftw (3.3.3) does not build if someone has texinfo-5 installed. This ticket covers upgrading to version 3.3.4 which includes the required fixes. fftw is marked as a "u" third party package so is allowed to be upgraded periodically. The release notes for 3.3.4 indicate that there are only minor fixes in this release so we are not expecting any compatibility issues.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            This required some minor changes to the eupspkg.cfg.sh file in order to preserve timestamps. Without it the build failed on Jenkins because the .texi files looked like they had been modified and Jenkins does not have makeinfo installed. Once the timestamps were retained the build passed on Jenkins.

            Also tweaked to stop copying the .git directory and to stop removing the upstream directory.

            Show
            tjenness Tim Jenness added a comment - This required some minor changes to the eupspkg.cfg.sh file in order to preserve timestamps. Without it the build failed on Jenkins because the .texi files looked like they had been modified and Jenkins does not have makeinfo installed. Once the timestamps were retained the build passed on Jenkins. Also tweaked to stop copying the .git directory and to stop removing the upstream directory.
            Hide
            nlust Nate Lust added a comment -

            Everything looks good, and builds for me. I probably should have used -a to start with as it does not really hurt to, I just didn't think things like time stamps would be too important for this. One minor things to ask is if you would put a comment in about excluding the git dir from the sub directories. In the past on certain cases I have had eupspkg have issues if the git directory is not present. I'm not sure when that comes up, or if that will ever be an issue here, but commenting to let someone know if the encounter something like that, may save someone time in the future. Otherwise looks good to merge

            Show
            nlust Nate Lust added a comment - Everything looks good, and builds for me. I probably should have used -a to start with as it does not really hurt to, I just didn't think things like time stamps would be too important for this. One minor things to ask is if you would put a comment in about excluding the git dir from the sub directories. In the past on certain cases I have had eupspkg have issues if the git directory is not present. I'm not sure when that comes up, or if that will ever be an issue here, but commenting to let someone know if the encounter something like that, may save someone time in the future. Otherwise looks good to merge
            Hide
            tjenness Tim Jenness added a comment -

            Merged. Comment added, although git will walk up the tree to look for a .git directory so it should have no problem finding it in the parent.

            Show
            tjenness Tim Jenness added a comment - Merged. Comment added, although git will walk up the tree to look for a .git directory so it should have no problem finding it in the parent.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              vpk24 Vishal Kasliwal [X] (Inactive)
              Reviewers:
              Nate Lust
              Watchers:
              Nate Lust, Tim Jenness, Vishal Kasliwal [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.