Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37911

Write dipoleNdata fields to APDB

    XMLWordPrintable

    Details

    • Story Points:
      8
    • Epic Link:
    • Sprint:
      AP F23-3 (August), AP F23-4 (September)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Information about the dipole fits is missing from APDB. The dipoleNdata, dipoleLnl, dipoleCov fields (currently dipNdata, dipLnl, dipCov, but to be renamed in DM-37196) are marked "not implemented" in DiaSource.yaml. This probably requires something like DM-29346, to add the relevant calculations to the SourceCatalog during dipole fitting; we don't have any fields in our current SourceCatalogs that hold these values, that I can tell.

      Brianna's original text:

      When loading from the apdb, the "dipNdata" column only contains zeros, even if the source is marked as a dipole. The following notebook shows an example of the empty column. https://github.com/lsst-dm/ap_pipe-notebooks/blob/tickets/DM-32197/notebooks/DM-32197-Reduced_Chi2_Notebook.ipynb

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-40185 Use the Chi2 to set a realiability flag in the dipole fitter

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29346 Compute PSFlux chi squared metric

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-37196 Modernize APDB schema to reflect desired usage (decl -> dec)

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31193 Add new PSF chi2/npixels fields to apdb

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            bsmart Brianna Smart added a comment -

            Jenkins run: https://rubin-ci.slac.stanford.edu/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/41/pipeline

            Show
            bsmart Brianna Smart added a comment - Jenkins run: https://rubin-ci.slac.stanford.edu/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/41/pipeline
            Hide
            Permalink
            bsmart Brianna Smart added a comment -

            I ran Jenkins and it was happy. My only issue is I can't seem to determine what is failing with the yaml validator in sdm_schemas.

            Show
            bsmart Brianna Smart added a comment - I ran Jenkins and it was happy. My only issue is I can't seem to determine what is failing with the yaml validator in sdm_schemas.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            I think it is still ok to ignore the linter errors.  See, e.g.

            https://lsstc.slack.com/archives/C8EEUGDSA/p1672696536894569

            https://lsstc.slack.com/archives/C2JPMCF5X/p1672962313206459

             

            Show
            lauren Lauren MacArthur added a comment - I think it is still ok to ignore the linter errors.  See, e.g. https://lsstc.slack.com/archives/C8EEUGDSA/p1672696536894569 https://lsstc.slack.com/archives/C2JPMCF5X/p1672962313206459  
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            I had a couple of (hopefully minor) questions on GitHub. Overall this looks like a straightforward implementation to add a useful column, and I appreciate that you put all the dipole fitting data into a single entry instead of three. Let's do it!

            Show
            mrawls Meredith Rawls added a comment - I had a couple of (hopefully minor) questions on GitHub. Overall this looks like a straightforward implementation to add a useful column, and I appreciate that you put all the dipole fitting data into a single entry instead of three. Let's do it!

              People

              Assignee:
              bsmart Brianna Smart
              Reporter:
              bsmart Brianna Smart
              Reviewers:
              Meredith Rawls
              Watchers:
              Brianna Smart, Eric Bellm, Ian Sullivan, John Parejko, Krzysztof Findeisen, Lauren MacArthur, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.