Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3793

Upgrade wcslib to 5.9

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Infrastructure
    • Labels:
      None
    • Team:
      Alert Production

      Description

      Upgrade wcslib to version 5.9, as per RFC-89. This should not involve any API changes.

        Attachments

          Issue Links

            Activity

            Hide
            ctslater Colin Slater added a comment -

            I implemented the code changes suggested by Russell Owen, all of which were very helpful.

            Having an RFD on how we want to handle persisting TPV makes sense, but since this effort has dropped on my priority list, I think this is going to be delayed either until I find time to look into saving TPV or until John Parejko starts his WCS-generalization work.

            If anyone has a more pressing need for TPV, let me know.

            Show
            ctslater Colin Slater added a comment - I implemented the code changes suggested by Russell Owen , all of which were very helpful. Having an RFD on how we want to handle persisting TPV makes sense, but since this effort has dropped on my priority list, I think this is going to be delayed either until I find time to look into saving TPV or until John Parejko starts his WCS-generalization work. If anyone has a more pressing need for TPV, let me know.
            Hide
            swinbank John Swinbank added a comment - - edited

            Nate Lust discovered a crashing bug in WCSLIB 4.14 which is fixed in 5.10: see DM-4946 for details. What are our prospects for getting a WCSLIB upgrade in soon, regardless of other work required to support TPV?

            Show
            swinbank John Swinbank added a comment - - edited Nate Lust discovered a crashing bug in WCSLIB 4.14 which is fixed in 5.10: see DM-4946 for details. What are our prospects for getting a WCSLIB upgrade in soon, regardless of other work required to support TPV?
            Hide
            swinbank John Swinbank added a comment -

            Confirming the WCSLIB 5.13 currently on tickets/DM-3793 fixes the problem we've seen on DM-4946.

            Show
            swinbank John Swinbank added a comment - Confirming the WCSLIB 5.13 currently on tickets/ DM-3793 fixes the problem we've seen on DM-4946 .
            Hide
            ctslater Colin Slater added a comment -

            I split this branch into two parts, one that does the wcslib upgrade, and another that enables TPV support. Since the first part was uncontroversial in the review and was necessary for the upstream bugfixes, I left it in this ticket and merged it. I will open a new ticket for enabling TPV.

            Note that at this point we are upgrading to wcslib 5.13.

            Show
            ctslater Colin Slater added a comment - I split this branch into two parts, one that does the wcslib upgrade, and another that enables TPV support. Since the first part was uncontroversial in the review and was necessary for the upstream bugfixes, I left it in this ticket and merged it. I will open a new ticket for enabling TPV. Note that at this point we are upgrading to wcslib 5.13.
            Hide
            swinbank John Swinbank added a comment -

            Thanks very much Colin Slater!

            Show
            swinbank John Swinbank added a comment - Thanks very much Colin Slater !

              People

              • Assignee:
                ctslater Colin Slater
                Reporter:
                ctslater Colin Slater
                Reviewers:
                Russell Owen
                Watchers:
                Colin Slater, Hsin-Fang Chiang, John Parejko, John Swinbank, Russell Owen, Simon Krughoff, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: