Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-38027

Create example projects that load pre-commit hook config files from repo and execute in Jenkinsfile

    XMLWordPrintable

    Details

      Description

      This ticket is for modifying the ESS projects such that they

      • load the pre-commit hook config files from the ts_pre_commit_conf repo
      • call pre-commit in Jenkinsfile

        Attachments

          Activity

          Hide
          wvreeven Wouter van Reeven added a comment - - edited

          The ts_pre_commit_config project has been rewritten to not use centralized-pre-commit-config anymore. Instead, the ts_pre_commit_config project now contains code and all config files needed to setup any project with pre-commit.

          The three ESS projects and the Authorize CSC project have been set up to use the ts-pre-commit-config conda package. Note that (for now) those merely act as examples for how to incorporate ts-pre-commit-conf in a Jenkinsfile so no PRs have been opened for those.

          Show
          wvreeven Wouter van Reeven added a comment - - edited The ts_pre_commit_config project has been rewritten to not use centralized-pre-commit-config anymore. Instead, the ts_pre_commit_config project now contains code and all config files needed to setup any project with pre-commit. The three ESS projects and the Authorize CSC project have been set up to use the ts-pre-commit-config conda package. Note that (for now) those merely act as examples for how to incorporate ts-pre-commit-conf in a Jenkinsfile so no PRs have been opened for those.
          Hide
          wvreeven Wouter van Reeven added a comment -
          Show
          wvreeven Wouter van Reeven added a comment - ts_pre_commit_conf PR: https://github.com/lsst-ts/ts_pre_commit_conf/pull/5
          Hide
          rowen Russell Owen added a comment - - edited

          This looks really nice.

          For your example projects, I suggest updating README files to explain at least a bit how to install pre-commit. If you need more than a line or two, then a link to the docs (README) for details is probably better than adding too much info to every user package's README.

          Show
          rowen Russell Owen added a comment - - edited This looks really nice. For your example projects, I suggest updating README files to explain at least a bit how to install pre-commit. If you need more than a line or two, then a link to the docs (README) for details is probably better than adding too much info to every user package's README.

            People

            Assignee:
            wvreeven Wouter van Reeven
            Reporter:
            wvreeven Wouter van Reeven
            Reviewers:
            Russell Owen
            Watchers:
            Russell Owen, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.