Upon looking at this further, It probably is a serious thing to look into and fix, as it is swapping the variable names of arguments passed to the function. It would be a bad situation if two "orders" of calling the functions existed in the stack. Or worse still if everyone just "learned" that the arguments must be flipped, and the documentation indicated the wrong behavior.

Needs an RFC before this goes ahead.

Pulled your name out of a hat. But is change is extremely small.

Note that Merlin Fisher-Levine is travelling for the rest of this week — not sure when he'll be able to get to this review. If you don't mind waiting a few days, it should be fine.

NB Merlin has asked me to take over this review.

Changes to the code look good – thank you Perry Gee!

Some minor housekeeping issues to clear up:

• Some commit messages are malformed. Remember that the first line should be no more than 50 characters. Please fix here, here and here.
• Please make sure the e-mail address on your commits is associated with your GitHub account. You seem to be using a mix of pgee@physics.ucdavis.com and pgee@physics.ucdavis.edu (I assume both are valid?) — register them with GitHub here.

Other than that, assuming that you've tested these changes with Jenkins, feel free to go ahead and merge.

John Swinbank, I was hoping to develop contacts with some of the new DM staff so that getting reviews done would become easier. For meas_base and meas_algorithms, do you have a suggestion (among people who have been onboard for a year or so)?

Well, I don't think you need any further review on this ticket, so it's not a problem here.

However, for DM-9249, maybe Bob Armstrong would be a likely candidate?