Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-38152

Make zooniverseCutouts interface for getting footprint-based cutouts

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: analysis_ap
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      AP S23-5 (April)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      We need to be able to get AP ZooniverseCutouts using the SourceCatalog Footprints instead of the centroid/shape-based locations. This can help debugging pipeline failures, where e.g. the footprint is on chip but the centroid has been pushed off-chip (see DM-37421).

      Relatedly, I need to come up with a formula for making a square bbox from a rectangular one (to turn a non-square footprint into a square one, which simplifies the cutout layout). I don't think that needs any new code, just figuring out the right bbox calls.

      Splitting out the afw part of this work (a version of getCutouts that takes pixels and can return something that falls off the chip edge) to DM-38544, as I have a working version of the analysis_ap ZooniverseCutouts code, and will tweak it to use the DM-38544 changes once they're done.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Erin Howard: do you mind taking on this medium-sized (~100 lines) review? I wrote most of this code over a month ago, so I want to know if it's coherent. I added a test that mocks a footprint, and I've tested making a handful of cutouts from an ap_verify run with the new config, so it seems to work.

            PR: https://github.com/lsst/analysis_ap/pull/24

            Show
            Parejkoj John Parejko added a comment - Erin Howard : do you mind taking on this medium-sized (~100 lines) review? I wrote most of this code over a month ago, so I want to know if it's coherent. I added a test that mocks a footprint, and I've tested making a handful of cutouts from an ap_verify run with the new config, so it seems to work. PR: https://github.com/lsst/analysis_ap/pull/24
            Hide
            howarde7 Erin Howard added a comment -

            Everything looks good to me!

            Show
            howarde7 Erin Howard added a comment - Everything looks good to me!

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Erin Howard
              Watchers:
              Brianna Smart, Eric Bellm, Erin Howard, Ian Sullivan, Jim Bosch, John Parejko, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.