Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_modelfit
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Science Pipelines DM-W16-1, Science Pipelines DM-W16-2
-
Team:Data Release Production
Description
I've just fixed two rather critical bugs in the CModel code on the HSC side (they would have been introduced on the LSST side in the last transfer, DM-2977):
- The minInitialRadius configuration parameter had a default that is too small, causing many galaxies to be fit with point source models, leading to bad star/galaxy classifications. This is HSC-1306.
- There was a simple but important algebra error in the uncertainty calculation, making the uncertainty a strong function of magnitude. This is HSC-1313.
On the LSST side, the transfer should be quite simple; we'll have to rewrite a bit of code due to the difference in measurement frameworks, but there was very little to begin with (most of the effort in the HSC issues was in debugging).
Attachments
Issue Links
- mentioned in
-
Page Loading...
Activity
Bob Armstrong, could you take over this review from Nate Lust? It should be really simple, as I think you may have already reviewed almost the exact same code on the HSC side.
I found a small typo, that I commented on in github. Other than that the code looks good.
Nate, a small CModel review for you, reverting a change on the last big ticket you reviewed and fixing a trivial but critical bug introduced there.