Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3829

Enable sconsUtils to output contents of failed tests as well as reporting the number of failures

    Details

    • Team:
      Architecture

      Description

      Sometimes the output of scons when a multi-threaded build is executing makes it hard to determine which tests are failing and which are passing without looking in the .tests directly after the build completes. In a test build with eups distrib on a virtual machine scanning the directory is not always trivial.

      The proposal is for sconsUtils to be modified to dump the contents of the failed test output to standard output itself. It may be appropriate to restrict this verbose output to when an appropriate environment variable is set.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Please take a look at this minor patch to list the contents of the failed test files when a build fails. This was extremely useful when doing CI builds for the v11.0 release (DM-3815) and it is clearer for people doing their own builds as the failures turn up in the log. I had initially ponded using an environment variable to control the output so that only CI builds would enable it but on further reflection I'm inclined to always send the output. Comments welcomed.

            Show
            tjenness Tim Jenness added a comment - Please take a look at this minor patch to list the contents of the failed test files when a build fails. This was extremely useful when doing CI builds for the v11.0 release ( DM-3815 ) and it is clearer for people doing their own builds as the failures turn up in the log. I had initially ponded using an environment variable to control the output so that only CI builds would enable it but on further reflection I'm inclined to always send the output. Comments welcomed.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            I opened a github PR so comments wouldn't get lost in the either.

            Show
            jhoblitt Joshua Hoblitt added a comment - I opened a github PR so comments wouldn't get lost in the either.
            Hide
            rowen Russell Owen added a comment -

            This looks great.

            I like the new feature and agree that always showing the failed output is probably best. It's certainly what I normally want for personal use (though I would be content with the new list of failed tests). If a use case comes up for hiding the test output we can make that a new ticket.

            Show
            rowen Russell Owen added a comment - This looks great. I like the new feature and agree that always showing the failed output is probably best. It's certainly what I normally want for personal use (though I would be content with the new list of failed tests). If a use case comes up for hiding the test output we can make that a new ticket.
            Hide
            tjenness Tim Jenness added a comment -

            Merged.

            Show
            tjenness Tim Jenness added a comment - Merged.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Joshua Hoblitt, Russell Owen
                Watchers:
                Joshua Hoblitt, Paul Price, Russell Owen, Tim Jenness
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel