Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-38542

Simplify ESS accelerometer code

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Story Points:
      1
    • Sprint:
      TSSW Sprint - Mar 27 - Apr 10
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      The ESS accelerometer code has gotten very complicated and I would like to simplify it as follows:

      • Eliminate the min_frequency config parameter and always use 0. This will fix (make constant) the number of raw samples that go into one accelerometerPSD message. To compute fancier PSDs, get raw data from the EFD.
      • Always publish the raw data (accelerometer topic): eliminate the config switch that allows turning this off.
      • Update the XML so that the raw accelerometer topic has the correct length arrays so that there can be one accelerometer message for each accelerometerPSD message.

        Attachments

          Issue Links

            Activity

            Show
            rowen Russell Owen added a comment - - edited Pull requests: https://github.com/lsst-ts/ts_ess_labjack/pull/20 https://github.com/lsst-ts/ts_xml/pull/684 https://github.com/lsst-ts/ts_ess_csc/pull/91 https://github.com/lsst-ts/ts_config_ocs/pull/166
            Hide
            ecoughlin Eric Coughlin added a comment -

            Reviewed on GitHub.

             

            Show
            ecoughlin Eric Coughlin added a comment - Reviewed on GitHub.  
            Hide
            rowen Russell Owen added a comment -

            Merged all to develop. Release awaits DM-38126

            Show
            rowen Russell Owen added a comment - Merged all to develop. Release awaits DM-38126

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Eric Coughlin
              Watchers:
              Brian Stalder, Craig Lage, Eric Coughlin, Patrick Ingraham, Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.