Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-38592

Support U64 and I64 in convertToKeyValuePair.vi

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:

      Description

      Support U64 and I64 in convertToKeyValuePair.vi in TCP/IP module. At this moment, it only supports the integer type until U32 or I32.

      Note you would need to consider the overflow of double data type if you would like to reuse the existed code of double.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-37941 Support the M2 Cell TCP/IP Interface with Json Packet in Phase 13

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            pcortes Patricio Cortes added a comment - - edited

            Please help to check the pull request.

            • I modified the name of functions to see the data type in the name (i.e. convertToKeyValuePair_unsignedInteger32bit.vi  and convertToKeyValuePair_integer64bit.vi).
            • I did not want to complex the code in the I64 and U64 functions. I tried to keep it as simple as possible.

            Thanks.

            Show
            pcortes Patricio Cortes added a comment - - edited Please help to check the pull request. I modified the name of functions to see the data type in the name (i.e. convertToKeyValuePair_unsignedInteger32bit.vi   and  convertToKeyValuePair_integer64bit.vi ). I did not want to complex the code in the I64 and U64 functions. I tried to keep it as simple as possible. Thanks.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Reviewed in GitHub.

            Show
            ttsai Te-Wei Tsai added a comment - Reviewed in GitHub.

              People

              Assignee:
              pcortes Patricio Cortes
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Te-Wei Tsai
              Watchers:
              Patricio Cortes, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.