Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-38622

photutils 1.7.0 breaks spectractor due to use of deprecated make_source_mask method

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: spectractor
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Team:
      Commissioning
    • Urgent?:
      No

      Description

        Attachments

          Issue Links

          is triggering

          Bug - A problem which impairs or prevents the functions of the product. DM-38623 Pin photutils at <1.7.0 until spectractor bug is fixed

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            The removal of the deprecated method was https://github.com/astropy/photutils/commit/5f097016564e58b7e5520b826dfccdebb7afc2be.
            It has been deprecated since 1.5.0. See https://github.com/astropy/photutils/blob/efe8a309e4d2e3df52005e4497268680dcf90c2c/photutils/segmentation/detect.py#L404.
            Usage is at https://github.com/lsst/Spectractor/blob/lsst-dev/spectractor/extractor/background.py#L13.

            Show
            ktl Kian-Tat Lim added a comment - The removal of the deprecated method was https://github.com/astropy/photutils/commit/5f097016564e58b7e5520b826dfccdebb7afc2be . It has been deprecated since 1.5.0. See https://github.com/astropy/photutils/blob/efe8a309e4d2e3df52005e4497268680dcf90c2c/photutils/segmentation/detect.py#L404 . Usage is at https://github.com/lsst/Spectractor/blob/lsst-dev/spectractor/extractor/background.py#L13 .
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Looks good, but I reinstated the backward compatibility by using the footprint= argument that has been around for a while as opposed to the brand-new size= argument, at least until rubin-env 6.0 can pin the minimum version of photutils.

            Show
            ktl Kian-Tat Lim added a comment - Looks good, but I reinstated the backward compatibility by using the footprint= argument that has been around for a while as opposed to the brand-new size= argument, at least until rubin-env 6.0 can pin the minimum version of photutils.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Running Jenkins to make sure nothing else breaks...

            Show
            ktl Kian-Tat Lim added a comment - Running Jenkins to make sure nothing else breaks...
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            I did an end to end test with pipetatsk with both 1.6.0 and 1.7.0 photutils and both passed, so feel free to merge whenever you want it.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - I did an end to end test with pipetatsk with both 1.6.0 and 1.7.0 photutils and both passed, so feel free to merge whenever you want it.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            My Jenkins test (which may have at least partially duplicated what you did) also succeeded. Merged.

            Show
            ktl Kian-Tat Lim added a comment - My Jenkins test (which may have at least partially duplicated what you did) also succeeded. Merged.

              People

              Assignee:
              mfisherlevine Merlin Fisher-Levine
              Reporter:
              ktl Kian-Tat Lim
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Kian-Tat Lim, Merlin Fisher-Levine
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.