Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: daf_butler
-
Labels:
-
Story Points:1
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
Apparently at least butler query-data-ids calls the count method on a query result object without telling it what to do when counting the results would have to be implemented by iterating over all results and then throwing them away, resulting in an error that uses shouldn't have to see in a high-level call like this:
https://lsstc.slack.com/archives/C01FBUGM2CV/p1682469497459669
This bug was introduced in DM-31725, but the behavior before was not great either, as it would have just silently run the query twice and thrown away the results from the first call after counting them.
Attachments
Issue Links
- relates to
-
DM-31725 Rewrite butler registry.queries subpackage
- Done
Andy Salnikov, mind reviewing this small fix (and unit test improvement) for query-data-ids?
PR is https://github.com/lsst/daf_butler/pull/833
Jenkins is underway at https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/38587/pipeline