Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-38953

Dynamic connection support and miscellaneous cleanups

    XMLWordPrintable

    Details

      Description

      This was originally is a spin-off of several miscellaneous cleanup commits from DM-33027, in order to merge them sooner and shrink what's still shaping up to be a very large review, but one of those commits that modified the construction pattern for PipelineTaskConnections proved useful in formalizing support for adding, replacing, and removing connections base on construction, so that's now by far the most important piece of this ticket.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-38952 Add ci_middleware package

          • Done
          is duplicated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-28769 Provide hooks for creating and fully modifying connections in PipelineTaskConnections subclasses

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-29658 Support dynamic generation of PipelineTask connections

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33027 Add pipeline graph class and experimental support for writing pipelines in expanded form

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Andy Salnikov, this is a ticket with no overriding theme other than the fact that I found the problems while working on the PipelineGraph class coming on DM-33027. I've pushed finishing that ticket back behind standing up ci_middleware on DM-38952, but to get the mock stuff working again the way I'd like, I need some of the commits here (the improved support for dynamic connections).

            • pipe_base has almost all of the changes
            • pex_config fixes some typos in comments
            • verify is a tiny adaptation to the dynamic-connections changes
            • analysis_drp is also a tiny adaptation to the dynamic-connections changes.
            Show
            jbosch Jim Bosch added a comment - Andy Salnikov , this is a ticket with no overriding theme other than the fact that I found the problems while working on the PipelineGraph class coming on DM-33027 . I've pushed finishing that ticket back behind standing up ci_middleware on DM-38952 , but to get the mock stuff working again the way I'd like, I need some of the commits here (the improved support for dynamic connections). pipe_base has almost all of the changes pex_config fixes some typos in comments verify is a tiny adaptation to the dynamic-connections changes analysis_drp is also a tiny adaptation to the dynamic-connections changes.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Taking this out of review for a bit (I hope you weren't starting on it over the weekend anyway), as I found a bit more dynamic-connections functionality I need on DM-38952 and it makes more sense to add it here.

            Show
            jbosch Jim Bosch added a comment - Taking this out of review for a bit (I hope you weren't starting on it over the weekend anyway), as I found a bit more dynamic-connections functionality I need on DM-38952 and it makes more sense to add it here.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Ok, this is one again ready for review, and I'm handing it to Nate Lust since he's expressed interest in the new scope, so Andy Salnikov is off the hook.

            Package PR summary a few posts above is still accurate.

            Show
            jbosch Jim Bosch added a comment - Ok, this is one again ready for review, and I'm handing it to Nate Lust since he's expressed interest in the new scope, so Andy Salnikov is off the hook. Package PR summary a few posts above is still accurate.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Marked this as reviewed on Nate's behalf after an in-person conversation.

            Show
            jbosch Jim Bosch added a comment - Marked this as reviewed on Nate's behalf after an in-person conversation.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Merges were reverted after an unexpected failure in verify on main; it seems there must have been some user error in my Jenkinsing prior to merge.

            Show
            jbosch Jim Bosch added a comment - Merges were reverted after an unexpected failure in verify on main; it seems there must have been some user error in my Jenkinsing prior to merge.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Fixed, tested, and merged.

            Show
            jbosch Jim Bosch added a comment - Fixed, tested, and merged.

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Nate Lust
              Watchers:
              Andy Salnikov, Jim Bosch, Nate Lust
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.