Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-39139

Improve base test class in ts_tcpip

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      2
    • Sprint:
      TSSW Sprint - May 08 - May 22
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Wouter and I decided that the new base class for server unit tests in ts_tcpip was not flexible enough. Beef it up and use it to test OneClientServer as well as OneClientReadLoopServer.

      Also improve some class attribute docs:

      • BaseClientOrServer.start_task is written for clients, not servers.
      • BaseClientOrServer.should_be_connected is unnecessarily verbose; tighten it up and clarify it
      • Reduce duplication in subclasses. I have not found a great way to do this, but it is easy to add a link to the subclass docs.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -
          Show
          rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_tcpip/pull/23
          Hide
          wvreeven Wouter van Reeven added a comment -

          Reviewed on GitHub.

          Show
          wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.
          Hide
          rowen Russell Owen added a comment -

          Merged to develop (after addressing reviewer comments) and that tagged v1.1.0.beta.1. If practical I would like to try this a bit before a final tag – make sure that the new classes will indeed do what we want (especially BaseOneClientServerTestCase – I am pretty confident about OneClientReadLoopServer).

          I also forced main back to v1.0.1 and deleted the v1.1.0 tag.

          Show
          rowen Russell Owen added a comment - Merged to develop (after addressing reviewer comments) and that tagged v1.1.0.beta.1. If practical I would like to try this a bit before a final tag – make sure that the new classes will indeed do what we want (especially BaseOneClientServerTestCase – I am pretty confident about OneClientReadLoopServer). I also forced main back to v1.0.1 and deleted the v1.1.0 tag.
          Hide
          rowen Russell Owen added a comment -

          Additional pull requests for issues discovered after the first one:

          Show
          rowen Russell Owen added a comment - Additional pull requests for issues discovered after the first one: https://github.com/lsst-ts/ts_tcpip/pull/24 https://github.com/lsst-ts/ts_tcpip/pull/25

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Wouter van Reeven
            Watchers:
            Russell Owen, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.