Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3915

Unused local typedef warning in Qserv

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None
    • Templates:
    • Team:
      Architecture

      Description

      Now that DM-3803 has fixed most of the warnings there is one residual warning in Qserv:

      core/modules/qana/RelationGraph.cc:956:44: error: unused typedef 'VecIter' [-Werror,-Wunused-local-typedef]
          typedef std::vector<Vertex*>::iterator VecIter;
                                                 ^
      

      The fix is simple:

      diff --git a/core/modules/qana/RelationGraph.cc b/core/modules/qana/RelationGraph.cc
      index a826c04..79a2fd9 100644
      --- a/core/modules/qana/RelationGraph.cc
      +++ b/core/modules/qana/RelationGraph.cc
      @@ -953,7 +953,6 @@ void RelationGraph::rewrite(SelectStmtPtrVector& outputs,
                                   QueryMapping& mapping)
       {
           typedef std::list<Vertex>::iterator ListIter;
      -    typedef std::vector<Vertex*>::iterator VecIter;
       
           if (!_query) {
               return;
      

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  tjenness Tim Jenness
                  Reporter:
                  tjenness Tim Jenness
                  Reviewers:
                  Fritz Mueller
                  Watchers:
                  Fritz Mueller, Tim Jenness
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel