Data ManagementIcon indicating the project type

Data Management

Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3920

Replace boost::regex with std::regex

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None

      Description

      Boost 1.59 causes a "keyword hidden by macro" warn under clang in the regex package. We should be using std::regex now anyway, so this is a good motivator to go ahead and convert.

        Attachments

          Issue Links

          is triggered by

          Improvement - An improvement or enhancement to an existing feature or task. DM-3803 Fix Qserv compiler warnings with clang

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5880 Audit use of Boost in the stack and remove it where possible

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-100 Switch from boost::shared_ptr to std::shared_ptr

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            fritzm Fritz Mueller added a comment -

            This was super quick, so I just went ahead and dealt with it – pr forthwith...

            Show
            fritzm Fritz Mueller added a comment - This was super quick, so I just went ahead and dealt with it – pr forthwith...
            Hide
            Permalink
            fritzm Fritz Mueller added a comment -

            Well, works fine on clang and gcc 4.9, but jenkins rejects it for gcc 4.8. Template deduction problem triggered by operator== on regex_iterator. Maybe there's a workaround, but putting this on the back-burner for now to get back to other things...

            Show
            fritzm Fritz Mueller added a comment - Well, works fine on clang and gcc 4.9, but jenkins rejects it for gcc 4.8. Template deduction problem triggered by operator== on regex_iterator. Maybe there's a workaround, but putting this on the back-burner for now to get back to other things...
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Well, looks like 4.9 is required. From the release notes:

            • Improved support for C++11, including: support for <regex>;
            Show
            tjenness Tim Jenness added a comment - Well, looks like 4.9 is required. From the release notes : Improved support for C++11, including: support for <regex>;
            Hide
            Permalink
            fritzm Fritz Mueller added a comment -

            Yup. This goes back on the backlog – we won't cut over to std::regex until the gcc baseline moves up to 4.9

            Show
            fritzm Fritz Mueller added a comment - Yup. This goes back on the backlog – we won't cut over to std::regex until the gcc baseline moves up to 4.9
            Hide
            Permalink
            fritzm Fritz Mueller added a comment -

            Dropping this for now. Some further experience with std::regex while working on data distribution prototype uncovered that it is quite a bit less featureful than boost::regex. I think the warnings that were motivating this have also been addressed in more recent versions of boost.

            Show
            fritzm Fritz Mueller added a comment - Dropping this for now. Some further experience with std::regex while working on data distribution prototype uncovered that it is quite a bit less featureful than boost::regex. I think the warnings that were motivating this have also been addressed in more recent versions of boost.

              People

              • Assignee:
                fritzm Fritz Mueller
                Reporter:
                fritzm Fritz Mueller
                Watchers:
                Fritz Mueller, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel