Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-39209

Use the Latest ts_tcpip Package in ts_m2com Package

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Jun 19 - Jul 03
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Use the latest ts_tcpip package in ts_m2com package.

      From Russell:
      ts_tcpip v1.1.0 is now tagged and the conda package built. If you use this package, please run your unit tests and update your code if you see any warnings (which would likely be due to calling read or write methods on the underlying reader or writer attributes, which are now supposed to be private). There are high-level read and write methods on Client and OneClientServer, including new read_str, write_str, read_json, and write_json methods — which I suspect are what most code should be using. Also if you use OneClientServer, please look into using OneClientReadLoopServer instead. It will simplify your code. Thanks to Wouter for the improvements.

        Attachments

          Activity

          Hide
          ttsai Te-Wei Tsai added a comment -
          Show
          ttsai Te-Wei Tsai added a comment - Please help to review the PRs: 1.  https://github.com/lsst-ts/ts_m2com/pull/39 2.  https://github.com/lsst-ts/ts_m2/pull/47 Thanks!
          Hide
          wvreeven Wouter van Reeven added a comment -

          The PRs don't really embrace the OneClientReadLoopServer concept but doing that would require quite a few code changes. Given that, it is good the way it has been done now.

          Show
          wvreeven Wouter van Reeven added a comment - The PRs don't really embrace the OneClientReadLoopServer concept but doing that would require quite a few code changes. Given that, it is good the way it has been done now.

            People

            Assignee:
            ttsai Te-Wei Tsai
            Reporter:
            ttsai Te-Wei Tsai
            Reviewers:
            Wouter van Reeven
            Watchers:
            Te-Wei Tsai, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.