Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-39338

flatten arrays in photodiode calibration

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: cp_pipe, ip_isr
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Team:
      Data Release Production

      Description

      The current photodiode reading code is creating multi-dimension arrays when the data should only have a single dimension.  Add flatten calls as appropriate, and ensure this doesn't break code elsewhere (example: https://github.com/lsst/cp_pipe/blob/w.2023.20/python/lsst/cp/pipe/linearity.py#L319)

       

        Attachments

          Activity

          Hide
          Permalink
          czw Christopher Waters added a comment -

          I've also added tests that confirm the shape, and a missing test for the new `integrateChargeSum` method that prompted this ticket.

          Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/38841/pipeline

          Show
          czw Christopher Waters added a comment - I've also added tests that confirm the shape, and a missing test for the new `integrateChargeSum` method that prompted this ticket. Jenkins:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/38841/pipeline

            People

            Assignee:
            czw Christopher Waters
            Reporter:
            czw Christopher Waters
            Reviewers:
            Eli Rykoff
            Watchers:
            Christopher Waters, Eli Rykoff
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.