Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-39338

flatten arrays in photodiode calibration

    XMLWordPrintable

Details

    • Improvement
    • Status: Done
    • Resolution: Done
    • None
    • cp_pipe, ip_isr
    • None
    • 1
    • Data Release Production

    Description

      The current photodiode reading code is creating multi-dimension arrays when the data should only have a single dimension.  Add flatten calls as appropriate, and ensure this doesn't break code elsewhere (example: https://github.com/lsst/cp_pipe/blob/w.2023.20/python/lsst/cp/pipe/linearity.py#L319)

       

      Attachments

        Activity

          No builds found.
          czw Christopher Waters created issue -
          czw Christopher Waters made changes -
          Field Original Value New Value
          Summary flatted arrays in photodiode calibration flatten arrays in photodiode calibration
          czw Christopher Waters made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]

          I've also added tests that confirm the shape, and a missing test for the new `integrateChargeSum` method that prompted this ticket.

          Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/38841/pipeline

          czw Christopher Waters added a comment - I've also added tests that confirm the shape, and a missing test for the new `integrateChargeSum` method that prompted this ticket. Jenkins:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/38841/pipeline
          czw Christopher Waters made changes -
          Reviewers Eli Rykoff [ erykoff ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          erykoff Eli Rykoff made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          czw Christopher Waters made changes -
          Story Points 1
          czw Christopher Waters made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

          People

            czw Christopher Waters
            czw Christopher Waters
            Eli Rykoff
            Christopher Waters, Eli Rykoff
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.