Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3939

move camera factory methods from obs_lsstSim to afw

    XMLWordPrintable

Details

    • 5
    • Alert Production

    Description

      The methods defined in obs_lsstSim/bin/makeLsstCameraRepository.py can be easily adapted for use in generating arbitrary, non-LSST cameras. This is useful for the sims stack, both for testing purposes, and because members of other projects have begun asking us to use our code.

      This ticket will take those methods, make them fully LSST-agnostic, and place them in afw as utility functions. The code in obs_lsstSim will refer back to these afw methods.

      Attachments

        Activity

          No builds found.
          danielsf Scott Daniel created issue -
          danielsf Scott Daniel made changes -
          Field Original Value New Value
          Link This issue blocks SIM-1225 [ SIM-1225 ]

          Upon closer examination of makeLsstCameraRepository.py, there do appear to be lines of code written specifically for the LSST camera.

          I'm going to adjust the scope of this issue to create a class basicCameraFactory.py that will read in a text file describing the focal plane layout of a camera and output an afwCamerGeom.camera object. The camera thus output will have an essentially empty ampInfoTable, as the ampInfoTable is

          a) unnecessary for the specific sims uses I am imagining (mostly, we need to be able to create cameras to transform from RA, Dec to pixel position on arbitrary cameras) and

          b) the method makeAmpTables is where most of the LSST-specific code appears to be.

          danielsf Scott Daniel added a comment - Upon closer examination of makeLsstCameraRepository.py, there do appear to be lines of code written specifically for the LSST camera. I'm going to adjust the scope of this issue to create a class basicCameraFactory.py that will read in a text file describing the focal plane layout of a camera and output an afwCamerGeom.camera object. The camera thus output will have an essentially empty ampInfoTable, as the ampInfoTable is a) unnecessary for the specific sims uses I am imagining (mostly, we need to be able to create cameras to transform from RA, Dec to pixel position on arbitrary cameras) and b) the method makeAmpTables is where most of the LSST-specific code appears to be.
          danielsf Scott Daniel made changes -
          Reviewers Simon Krughoff [ krughoff ]
          Status To Do [ 10001 ] In Review [ 10004 ]

          I've taken a bit of a look, but I think we should talk in person. There are still a few LSST specific aspects, and I'd like to talk about the priority of adding an LSST agnostic makeAmpTables.

          krughoff Simon Krughoff (Inactive) added a comment - I've taken a bit of a look, but I think we should talk in person. There are still a few LSST specific aspects, and I'd like to talk about the priority of adding an LSST agnostic makeAmpTables.
          tjenness Tim Jenness made changes -
          Labels SciencePipelines
          tjenness Tim Jenness made changes -
          Team Alert Production [ 10300 ]

          Hey krughoff & danielsf — this has been in review for 18 months now with no obvious progress. Is it actually going anywhere?

          swinbank John Swinbank added a comment - Hey krughoff & danielsf — this has been in review for 18 months now with no obvious progress. Is it actually going anywhere?

          We decided to abort the effort. I will mark it as "won't fix".

          danielsf Scott Daniel added a comment - We decided to abort the effort. I will mark it as "won't fix".
          danielsf Scott Daniel made changes -
          Resolution Done [ 10000 ]
          Status In Review [ 10004 ] Won't Fix [ 10405 ]

          Thank you!

          swinbank John Swinbank added a comment - Thank you!

          People

            danielsf Scott Daniel
            danielsf Scott Daniel
            Simon Krughoff (Inactive)
            John Swinbank, Scott Daniel, Simon Krughoff (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.