Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3939

move camera factory methods from obs_lsstSim to afw

    XMLWordPrintable

    Details

    • Story Points:
      5
    • Team:
      Alert Production

      Description

      The methods defined in obs_lsstSim/bin/makeLsstCameraRepository.py can be easily adapted for use in generating arbitrary, non-LSST cameras. This is useful for the sims stack, both for testing purposes, and because members of other projects have begun asking us to use our code.

      This ticket will take those methods, make them fully LSST-agnostic, and place them in afw as utility functions. The code in obs_lsstSim will refer back to these afw methods.

        Attachments

          Activity

          Hide
          danielsf Scott Daniel added a comment -

          Upon closer examination of makeLsstCameraRepository.py, there do appear to be lines of code written specifically for the LSST camera.

          I'm going to adjust the scope of this issue to create a class basicCameraFactory.py that will read in a text file describing the focal plane layout of a camera and output an afwCamerGeom.camera object. The camera thus output will have an essentially empty ampInfoTable, as the ampInfoTable is

          a) unnecessary for the specific sims uses I am imagining (mostly, we need to be able to create cameras to transform from RA, Dec to pixel position on arbitrary cameras) and

          b) the method makeAmpTables is where most of the LSST-specific code appears to be.

          Show
          danielsf Scott Daniel added a comment - Upon closer examination of makeLsstCameraRepository.py, there do appear to be lines of code written specifically for the LSST camera. I'm going to adjust the scope of this issue to create a class basicCameraFactory.py that will read in a text file describing the focal plane layout of a camera and output an afwCamerGeom.camera object. The camera thus output will have an essentially empty ampInfoTable, as the ampInfoTable is a) unnecessary for the specific sims uses I am imagining (mostly, we need to be able to create cameras to transform from RA, Dec to pixel position on arbitrary cameras) and b) the method makeAmpTables is where most of the LSST-specific code appears to be.
          Hide
          krughoff Simon Krughoff added a comment -

          I've taken a bit of a look, but I think we should talk in person. There are still a few LSST specific aspects, and I'd like to talk about the priority of adding an LSST agnostic makeAmpTables.

          Show
          krughoff Simon Krughoff added a comment - I've taken a bit of a look, but I think we should talk in person. There are still a few LSST specific aspects, and I'd like to talk about the priority of adding an LSST agnostic makeAmpTables.
          Hide
          swinbank John Swinbank added a comment -

          Hey Simon Krughoff & Scott Daniel — this has been in review for 18 months now with no obvious progress. Is it actually going anywhere?

          Show
          swinbank John Swinbank added a comment - Hey Simon Krughoff & Scott Daniel — this has been in review for 18 months now with no obvious progress. Is it actually going anywhere?
          Hide
          danielsf Scott Daniel added a comment -

          We decided to abort the effort. I will mark it as "won't fix".

          Show
          danielsf Scott Daniel added a comment - We decided to abort the effort. I will mark it as "won't fix".
          Hide
          swinbank John Swinbank added a comment -

          Thank you!

          Show
          swinbank John Swinbank added a comment - Thank you!

            People

            Assignee:
            danielsf Scott Daniel
            Reporter:
            danielsf Scott Daniel
            Reviewers:
            Simon Krughoff
            Watchers:
            John Swinbank, Scott Daniel, Simon Krughoff
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.