Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3940

NaiveDipoleCentroid/NaiveDipoleFlux algorithms should not require centroid slot

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_diffim
    • Labels:
      None
    • Templates:
    • Story Points:
      0.5
    • Sprint:
      Science Pipelines DM-W16-1, Science Pipelines DM-W16-2
    • Team:
      Data Release Production

      Description

      The NaiveDipoleCentroid and NaiveDipoleFlux algorithms in ip_diffim have members which are instances of meas::base::SafeCentroidExtractor. Due to the prerequisites that imposes, it is impossible to initialize these algorithms without first defining a centroid slot.

      However, there is nothing in these algorithms which actually uses the SafeCentroidExtractor or any of the information stored in the slot; this seems to be an entirely arbitrary restriction which is likely a legacy of the port to the meas_base framework. We should remove the use of SafeCentroidExtractor to simply the code and make it easier to run the test suite (since it will no longer be necessary to run a centroider).

        Attachments

          Container Issues

            Issue Links

              Activity

                People

                • Assignee:
                  swinbank John Swinbank
                  Reporter:
                  swinbank John Swinbank
                  Reviewers:
                  Perry Gee
                  Watchers:
                  John Swinbank, Perry Gee, Yusra AlSayyad
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Summary Panel