Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_base
-
Labels:
-
Story Points:1
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
DM-31924 deprecated access to the simplest ways of getting a DimensionPacker in favor of more rigorously correct but difficult ways, and that turns out to be a problem a common AP data access pattern that's even being used in our tutorial notebooks.
The easiest fix is to add a method to lsst.pipe.base.Instrument that provides access to the default dimension packer for the instrument without having to create and use a pex.config.Field. That has some small chance of being wrong, if someone has overridden the default, but that should be exceptionally rare.
Attachments
Issue Links
Activity
Tim Jenness, I just realized I sent this to Meredith right when she went on strike and then I forgot about it. Could you take over?
This provides a better alternative to that deprecation warning that popped up in a tutorial notebook recently, though if that notebook can use recently processed data I think there may already be an even better option on main (in the form of separate visit and detector columns in the relevant catalog).
Looks okay to me.
Apologies Jim - thanks very much for implementing this, and thanks for reviewing in my absence, Tim!
Meredith Rawls, this is a tiny ticket that just hides the gnarly workaround I gave you for data ID-unpacking behind a more pleasant public method. Mind reviewing?
All changes in pipe_base.