Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: analysis_ap, analysis_tools, ap_verify, ci_hsc_gen3, ci_middleware, ctrl_bps, ctrl_mpexec, daf_butler, dax_obscore, ip_isr, jointcal, meas_algorithms, obs_base, obs_cfht, obs_decam, obs_lsst, obs_subaru, pipe_base, pipe_tasks, pipelines_check, skymap, verify
-
Labels:
-
Story Points:4
-
Epic Link:
-
Team:Ops Middleware
-
Urgent?:No
Description
Back in 2021 in DM-30966, we added butler.dimensions to the API. Unfortunately hardly anyone noticed and so we have a lot of code everywhere that still does butler.registry.dimensions.
The following packages need to be fixed as part of the migration to make butler.registry disappear.
- analysis_ap
- analysis_tools
- ap_pipe-notebooks
- ap_verify
- ci_hsc_gen3
- ci_middleware
- ctrl_bps
- ctrl_mpexec
- daf_butler
- daf_butler_migrate
- dax_obscore
- ip_isr
- jointcal
- meas_algorithms
- obs_base
- obs_cfht
- obs_decam
- obs_lsst
- obs_subaru
- pipe_base
- pipe_tasks
- pipelines_check
- skymap
- testdata_decam
- verify
I think the best plan is to do each package independently with tickets/DM-xxx-package branches so we do not have to keep lots of branches all rebased for one big review.
Attachments
Issue Links
- relates to
-
- Done
Activity
Remaining daf_butler changes (after Andy Salnikov's review of core and registry) look good to me. Most comments are suggestions to maybe go a little further, and note that I have not vetted any of my str -> ResourcePathExpression suggestions (for Config args, mostly) to see if they'd actually work.
I believe I have fixed all the packages in lsst_ci. Thanks to everyone that reviewed, and especially Andy Salnikov for doing some really big reviews.
I guess everything is reviewed already, so I just click complete button.
The analysis_tools PR looks good to me.