Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4008

Switch from boost::shared_ptr to std::shared_ptr

    Details

    • Type: Improvement
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Team:
      Alert Production

      Description

      Switch from boost::shared_ptr to std::shared_ptr. This also requires switching boost::make_shared to std::make_shared.

      This includes
      • In utils p_lsstSwig.i change from %include "boost_shared_ptr.i" to %include "std_shared_ptr.i". Note that the shared_vec macro defined in p_lsstSwig.i appears to not need any changes (though I do wonder if it is still required).
      • Change the PTR and CONST_PTR macros
      • Change .cc, .h and .i files; I found 1093 matches across 344 files (excluding qserv files, since qserv already switched)

      Note that qserv already switched

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            I agree with Jim Bosch; I am in favor of dropping CONST_PTR, but dropping that or PTR should be separate from this ticket.

            Jim Bosch is certainly right about boost::make_shared. A global search found 583 matches across 171 files, and I may not have everything checked out.

            Show
            rowen Russell Owen added a comment - I agree with Jim Bosch ; I am in favor of dropping CONST_PTR , but dropping that or PTR should be separate from this ticket. Jim Bosch is certainly right about boost::make_shared . A global search found 583 matches across 171 files, and I may not have everything checked out.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Ok, I will file a separate ticket for that. I agree that the macro's have made this a bit easier. But I also think that it is extremely unlikely we will need to do this again given that we are now using the standard. So now would be the right time to consider dropping it.

            I do however consider boost::make_shared -> std::make_shared to be part of this ticket.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Ok, I will file a separate ticket for that. I agree that the macro's have made this a bit easier. But I also think that it is extremely unlikely we will need to do this again given that we are now using the standard. So now would be the right time to consider dropping it. I do however consider boost::make_shared -> std::make_shared to be part of this ticket.
            Hide
            jbosch Jim Bosch added a comment -

            I do however consider boost::make_shared -> std::make_shared to be part of this ticket.

            Definitely. It almost certainly wouldn't work without that (I was just pointing out that PTR still doesn't make this ticket a one-line change to that macro).

            Show
            jbosch Jim Bosch added a comment - I do however consider boost::make_shared -> std::make_shared to be part of this ticket. Definitely. It almost certainly wouldn't work without that (I was just pointing out that PTR still doesn't make this ticket a one-line change to that macro).
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Well that, and the fact that the macro isn't consistently used.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Well that, and the fact that the macro isn't consistently used.
            Hide
            tjenness Tim Jenness added a comment -

            Work is being done in DM-5879

            Show
            tjenness Tim Jenness added a comment - Work is being done in DM-5879

              People

              • Assignee:
                Unassigned
                Reporter:
                rowen Russell Owen
                Watchers:
                Jim Bosch, John Swinbank, Kian-Tat Lim, Pim Schellart [X] (Inactive), Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel