Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_base
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:DRP X16-2, DRP X16-3, DRP F16-1
-
Team:Data Release Production
Description
The FlagHandler utility class makes it easier to manage the flags for a measurement algorithm, and using it also makes it possible to use the SafeCentroidExtractor and SafeShapeExtractor classes. Unfortunately, its constructor requires arguments that can only be provided in C++. A little extra Swig wrapper code should make it usable in Python as well.
Attachments
Issue Links
Activity
Hi Nate. I like it. It is more than I would have done with my knowledge of Python, but I think it is simpler for the user.
Is it OK with you if we put this off until I add the new example code during the next Sprint. I would just like to check in the FlagHandler code, and if you like, I can remove the Plugin example and do it next sprint.
Perry Gee
added a comment - Hi Nate. I like it. It is more than I would have done with my knowledge of Python, but I think it is simpler for the user.
Is it OK with you if we put this off until I add the new example code during the next Sprint. I would just like to check in the FlagHandler code, and if you like, I can remove the Plugin example and do it next sprint. Sounds good to me, just create a ticket and link it to this one before you merge. otherwise sounds like a good plan
by that I mean you can just leave it as is, and make a small ticket to merge in the convince function that is on my branch and the updates to the unit test
It would be nice if you changed the for loop in addFields to range based syntax, its not 100% necessary, but I think it would add clarity
Perry, see my changes on u/nlust/
DM-4009and see what you think. I added a decorator and updated the test plugin to use it