Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4032

obs_sdss should use pydl.yanny instead of it's own copy thereof

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_sdss
    • Labels:
      None
    • Story Points:
      4
    • Team:
      Alert Production

      Description

      Inside obs_sdss there is a yanny.py that looks like it was copied from either sdss_python_module or pydl. We should just depend on pydl (https://github.com/weaverba137/pydl), so we can use whatever improvements it gets for free, and to prevent yet annother yanny reader floating around.

        Attachments

          Issue Links

          is blocked by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-103 Add pydl as an external package dependency

          • Withdrawn

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Per the RFC, I'll update the included copy of yanny, note where it came from, and note where it is used and why we don't have said dependency.

            Show
            Parejkoj John Parejko added a comment - Per the RFC, I'll update the included copy of yanny, note where it came from, and note where it is used and why we don't have said dependency.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins build going on now

            Show
            Parejkoj John Parejko added a comment - Jenkins build going on now
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I updated yanny to a recent one from pydl, added a note to its header about why we need it, and fixed the pseudo-test associated with it in convertOpECalib.py to actually work.

            This should be a quick review.

            https://ci.lsst.codes/job/stack-os-matrix/4966/

            Show
            Parejkoj John Parejko added a comment - I updated yanny to a recent one from pydl, added a note to its header about why we need it, and fixed the pseudo-test associated with it in convertOpECalib.py to actually work. This should be a quick review. https://ci.lsst.codes/job/stack-os-matrix/4966/
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            Minor comments in PR.

            Show
            ktl Kian-Tat Lim added a comment - Minor comments in PR.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Fixed and responded in PR.

            Show
            Parejkoj John Parejko added a comment - Fixed and responded in PR.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Closed on tickets/DM-4032 branch, now merged into master.

            Show
            Parejkoj John Parejko added a comment - Closed on tickets/ DM-4032 branch, now merged into master.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Kian-Tat Lim
              Watchers:
              John Parejko, Kian-Tat Lim, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.