Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4048

Replace QsRestrictor::PtrVector With std::vector<QsRestrictor> and use move constructor

    Details

    • Type: Story
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Qserv
    • Labels:
      None
    • Story Points:
      5
    • Team:
      Data Access and Database

      Description

      Use of QsRestrictor::PtrVector introduces a useless indirection. it maybe could be replace by std::vector<QsRestrictor> and use of move constructor. This would simplify code (currently a confusion exists between empty vector and nullptr) and ease maintenance.

        Attachments

          Issue Links

            Activity

            Hide
            jbecla Jacek Becla added a comment -

            Fabrice, does it need to be done in order to complete DM-2873? If not, I'd make it a separate story (not child of DM-2873) and handle later.

            Show
            jbecla Jacek Becla added a comment - Fabrice, does it need to be done in order to complete DM-2873 ? If not, I'd make it a separate story (not child of DM-2873 ) and handle later.
            Hide
            jammes Fabrice Jammes added a comment -

            Jacek Becla, ok I removed this link. I wanted to emphasize that current issue has been discovered while doing DM-2873, so I keep a "relates to " relationship.

            Cheers,

            Fabrice

            Show
            jammes Fabrice Jammes added a comment - Jacek Becla , ok I removed this link. I wanted to emphasize that current issue has been discovered while doing DM-2873 , so I keep a "relates to " relationship. Cheers, Fabrice
            Hide
            jbecla Jacek Becla added a comment -

            Yup. And I tweaked it and changed to "is triggered by"

            Show
            jbecla Jacek Becla added a comment - Yup. And I tweaked it and changed to "is triggered by"
            Hide
            fritzm Fritz Mueller added a comment -

            Nate: since this involves qsrestrictor, it may be adjacent to code you will be looking at while working on the area restriction hinting. Could you please include this work, or simply close as “INVALID” if no longer relevant/desirable?

            Show
            fritzm Fritz Mueller added a comment - Nate: since this involves qsrestrictor, it may be adjacent to code you will be looking at while working on the area restriction hinting. Could you please include this work, or simply close as “INVALID” if no longer relevant/desirable?
            Hide
            npease Nate Pease added a comment -

            I'm going to go with Invalid on this; most (all?) of the intermediate representation classes (the query classes) are managed by pointers, and making this change would make QsRestrictor a special case.

            Show
            npease Nate Pease added a comment - I'm going to go with Invalid on this; most (all?) of the intermediate representation classes (the query classes) are managed by pointers, and making this change would make QsRestrictor a special case.

              People

              • Assignee:
                npease Nate Pease
                Reporter:
                jammes Fabrice Jammes
                Watchers:
                Andy Salnikov, Fabrice Jammes, Fritz Mueller, Jacek Becla, Nate Pease
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel