Details

    • Type: Technical task
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Team:
      SQuaRE

      Description

      Currently, all POST operations result in a github API call. This can result in running into the github 5K/hour API call limit on a per user basis. It also adds latency to each lfs API call. A workaround would be to cache user authentication on a short time frame (perhaps 15min) .

      App 24366 stderr: 2015-10-16 13:24:48 - Octokit::TooManyRequests - GET https://api.github.com/user: 403 - API rate limit exceeded for jhoblitt. // See: https://developer.github.com/v3/#rate-limiting:
      

        Attachments

          Activity

          Hide
          jmatt J Matt Peterson [X] (Inactive) added a comment -

          If redis is missing or disconnected it still verifies through the GitHub API and warns in the logs.

          Note: I'm not particularly happy with the organization of the code.

          Show
          jmatt J Matt Peterson [X] (Inactive) added a comment - If redis is missing or disconnected it still verifies through the GitHub API and warns in the logs. Note: I'm not particularly happy with the organization of the code.
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          J Matt Peterson [X] Could you open a PR?

          Show
          jhoblitt Joshua Hoblitt added a comment - J Matt Peterson [X] Could you open a PR?
          Hide
          jhoblitt Joshua Hoblitt added a comment -

          Oh, I see, you've already merged it. I guess I will try to comment directly on the commits then.

          Show
          jhoblitt Joshua Hoblitt added a comment - Oh, I see, you've already merged it. I guess I will try to comment directly on the commits then.
          Hide
          jmatt J Matt Peterson [X] (Inactive) added a comment -

          Yeah my bad, next time. It's mostly just this commit:

          https://github.com/lsst-sqre/git-lfs-s3-server/commit/ea89bcf55746d15ae1705ae0fb542a479d5f2c6e

          I fixed my message for the scrypt dependency too.

          Show
          jmatt J Matt Peterson [X] (Inactive) added a comment - Yeah my bad, next time. It's mostly just this commit: https://github.com/lsst-sqre/git-lfs-s3-server/commit/ea89bcf55746d15ae1705ae0fb542a479d5f2c6e I fixed my message for the scrypt dependency too.
          Show
          jhoblitt Joshua Hoblitt added a comment - I have added comments to https://github.com/lsst-sqre/git-lfs-s3-server/commit/ea89bcf55746d15ae1705ae0fb542a479d5f2c6e Note that the commit message for https://github.com/lsst-sqre/git-lfs-s3-server/commit/d62d945889b3abef946dddc57a4ba00a5e2acb27 is incorrect.

            People

            • Assignee:
              jmatt J Matt Peterson [X] (Inactive)
              Reporter:
              jhoblitt Joshua Hoblitt
              Reviewers:
              Joshua Hoblitt
              Watchers:
              J Matt Peterson [X] (Inactive), Joshua Hoblitt
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel