Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3921 Create and deploy a git-lfs prototype
  3. DM-4108

Aws.config should not be directly modified when not using ceph

    Details

    • Type: Technical task
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Templates:
    • Team:
      SQuaRE

      Description

      The current behavior breaks the s3 endpoint select and results in an error unless LFS_CEPH_ENDPOINT is defined.

      A simple conditional should fix it:
      Eg.:

      if GitLfsS3::Application.settings.ceph_s3
        Aws.config.update(
          endpoint: ENV['LFS_CEPH_ENDPOINT'],
          access_key_id: ENV['AWS_ACCESS_KEY_ID'],
          secret_access_key: ENV['AWS_SECRET_ACCESS_KEY'],
          force_path_style: true,
          region: 'us-east-1',
          # ssl_ca_bundle: '/usr/local/etc/openssl/cert.pem' # Required for brew install on a mac.
        )     
      end
      
      

        Attachments

          Container Issues

            Activity

              People

              • Assignee:
                jmatt J Matt Peterson [X] (Inactive)
                Reporter:
                jhoblitt Joshua Hoblitt
                Watchers:
                J Matt Peterson [X] (Inactive), Joshua Hoblitt
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel