Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4113

add lfs remote support to lsstsw/lsst_build

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: lsst_build, lsstsw
    • Labels:
      None

      Description

      Support for cloning from lfs backed repos, when indicated via repos.yaml, is needed.

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            Are the only issues here doing a "git lfs init" at some point and dealing with the authentication prompts? I would hope that there is no other change necessary, as git-lfs remotes should otherwise work the same as normal git remotes.

            Show
            ktl Kian-Tat Lim added a comment - Are the only issues here doing a "git lfs init" at some point and dealing with the authentication prompts? I would hope that there is no other change necessary, as git-lfs remotes should otherwise work the same as normal git remotes.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            The main concern is dealing with the auth prompting but obviously git-lfs also needs to be installed as part of deploy.

            Show
            jhoblitt Joshua Hoblitt added a comment - The main concern is dealing with the auth prompting but obviously git-lfs also needs to be installed as part of deploy.
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            The lsstsw PR is essentially finished but shouldn't be merged until DM-4128 is resolved, as the lfs version set in bin/deploy will need to be updated. The lsst_build PR should be ready for merge.

            Show
            jhoblitt Joshua Hoblitt added a comment - The lsstsw PR is essentially finished but shouldn't be merged until DM-4128 is resolved, as the lfs version set in bin/deploy will need to be updated. The lsst_build PR should be ready for merge.
            Hide
            tjenness Tim Jenness added a comment -

            Looks ok to me. Will leave J Matt Peterson [X] to review.

            Show
            tjenness Tim Jenness added a comment - Looks ok to me. Will leave J Matt Peterson [X] to review.
            Hide
            jmatt J Matt Peterson [X] (Inactive) added a comment -

            Comments are in the GitHub PRs.

            +1

            Show
            jmatt J Matt Peterson [X] (Inactive) added a comment - Comments are in the GitHub PRs. +1
            Hide
            jhoblitt Joshua Hoblitt added a comment -

            The PR for lsst_build has been merged. A new problem with git-lfs 1.0.1 & 1.0.2 are now blocking the merge into lsstsw.

            Show
            jhoblitt Joshua Hoblitt added a comment - The PR for lsst_build has been merged. A new problem with git-lfs 1.0.1 & 1.0.2 are now blocking the merge into lsstsw .

              People

              • Assignee:
                jhoblitt Joshua Hoblitt
                Reporter:
                jhoblitt Joshua Hoblitt
                Reviewers:
                J Matt Peterson [X] (Inactive), Tim Jenness
                Watchers:
                J Matt Peterson [X] (Inactive), Joshua Hoblitt, Kian-Tat Lim, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel