Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4133

Change type of LTV1/2 from int to float when writing afw images to FITS

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Templates:
    • Story Points:
      1
    • Sprint:
      Science Pipelines DM-W16-4
    • Team:
      Data Release Production

      Description

      The LTV1/2 problem is originally my bug. I used integer LTV1/2 in

      afw/src/image/ExposureInfo.cc:    data.imageMetadata->set("LTV1", -xy0.getX());
      afw/src/image/ExposureInfo.cc:    data.imageMetadata->set("LTV2", -xy0.getY());
      

      whereas a more careful reading of the NOAO page http://iraf.noao.edu/projects/ccdmosaic/imagedef/imagedef.html introducing them includes floating point examples.

      The fix is to cast the XY0 values to float. I'm not sure if there'll be any side effects of fixing this, but if so they'll be obvious and trivial.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                swinbank John Swinbank
                Reporter:
                rhl Robert Lupton
                Reviewers:
                Hsin-Fang Chiang
                Watchers:
                David Nidever [X] (Inactive), Hsin-Fang Chiang, John Swinbank, Robert Lupton
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel