Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-41640

Propagate calib_psf_used information to stars catalog in CalibrateImageTask

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • pipe_tasks
    • None

    Description

      We need the calib_psf_used flag field propagated from the psf_stars catalog to the stars catalog in CalibrateImage. This may require doing an x/y source match from psf_stars to the deeper stars catalog, or there may be a trick to use in how this is handled in Characterize/Calibrate.

      Attachments

        Issue Links

          Activity

            erykoff Eli Rykoff added a comment -

            This is the matching code that's used in calibrate. Amazingly, I had never noticed this block of code before. https://github.com/lsst/pipe_tasks/blob/281251e7f96dd79eed493ef630b2413ee0d107fd/python/lsst/pipe/tasks/calibrate.py#L714

            erykoff Eli Rykoff added a comment - This is the matching code that's used in calibrate . Amazingly, I had never noticed this block of code before. https://github.com/lsst/pipe_tasks/blob/281251e7f96dd79eed493ef630b2413ee0d107fd/python/lsst/pipe/tasks/calibrate.py#L714

            erykoff: since you pointed out the code from CalibrateTask, do you mind reviewing this ~100 line change? I took that old code and modernized some of it (to use numpy bool arrays instead of a SchemaMapper). The three commits are mostly independent.

            Parejkoj John Parejko added a comment - erykoff : since you pointed out the code from CalibrateTask, do you mind reviewing this ~100 line change? I took that old code and modernized some of it (to use numpy bool arrays instead of a SchemaMapper). The three commits are mostly independent.
            Parejkoj John Parejko added a comment - Jenkins: https://rubin-ci.slac.stanford.edu/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/400/pipeline
            erykoff Eli Rykoff added a comment -

            See minor comments on the PR.

            erykoff Eli Rykoff added a comment - See minor comments on the PR.

            People

              Parejkoj John Parejko
              Parejkoj John Parejko
              Eli Rykoff
              Eli Rykoff, Ian Sullivan, John Parejko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.