Data ManagementIcon indicating the project type

Data Management

Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4202

Revert temporary disabling of CModel in config override files

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      Science Pipelines DM-W16-6, DRP X16-3, DRP F16-1, DRP F16-2
    • Team:
      Data Release Production

      Description

      Revert the temporary disabling of CModel that relates to a bug noted in DM-4033 that was causing too many failures to test that processCcd (etc.) would run all the way to completion (most of the other fixes/updates related to the initial disabling in the multiband tasks have now been completed in DM-2977 & DM-3821).

      Relevant files:

      config/processCcd.py 
      config/forcedPhotCcd.py 
      config/forcedPhotCoadd.py 
      config/measureCoaddSources.py

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6464 Compare CModel results from LSST and HSC

          • Done
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. DM-6293 Fix error in cmodel related to computing LinearTransforms

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3957 Enable CModel in CalibrateTask prior to PhotoCal

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5197 Test and robustify shapelet PSF approximations

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6819 Resolve CModel issues with aperture corrections

          • Done
          is triggered by

          Bug - A problem which impairs or prevents the functions of the product. DM-4033 modelfit_CModel code occassionally tries to use uninitialized pointer

          • Won't Fix
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6925 star selector and PSF determiner are selecting stars that are not valid point sources

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I'll take this, as it's a natural finish to me getting CModel up and running.

            Show
            jbosch Jim Bosch added a comment - I'll take this, as it's a natural finish to me getting CModel up and running.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I started work on this while testing DM-5197 (which should fix most of the problems that led to CModel being disabled), but found that there are still some issues in the aperture corrections for CModel that lead to bad extendedness values (resulting in a ci_hsc failure).

            Investigating that isn't appropriate for DM-5197, so I'm increasing the story points of this issue instead, which should then start from the tickets/DM-4202 branch for obs_subaru I've created and resolve that aperture correction issue.

            Show
            jbosch Jim Bosch added a comment - I started work on this while testing DM-5197 (which should fix most of the problems that led to CModel being disabled), but found that there are still some issues in the aperture corrections for CModel that lead to bad extendedness values (resulting in a ci_hsc failure). Investigating that isn't appropriate for DM-5197 , so I'm increasing the story points of this issue instead, which should then start from the tickets/ DM-4202 branch for obs_subaru I've created and resolve that aperture correction issue.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Following discussion with Nate on 2016-06-29, adding DM-6819 as a blocker.

            Show
            swinbank John Swinbank added a comment - Following discussion with Nate on 2016-06-29, adding DM-6819 as a blocker.
            Hide
            Permalink
            nlust Nate Lust added a comment - - edited

            Bob, I know you were talking about using CModel soon, so I wonder if you would mind reviewing this for me. There should be a branch in obs_subaru and a branch in ci_hsc. If you are satisfied with the changes, or do whatever fixes you see fit, feel free to merge this while I am gone (just do one last ci_hsc run for me if you do). If not I will take care of it when I am back. If you do not want to review it, or don't have time, John said to talk with him and he will find someone else. Thanks!

            Show
            nlust Nate Lust added a comment - - edited Bob, I know you were talking about using CModel soon, so I wonder if you would mind reviewing this for me. There should be a branch in obs_subaru and a branch in ci_hsc. If you are satisfied with the changes, or do whatever fixes you see fit, feel free to merge this while I am gone (just do one last ci_hsc run for me if you do). If not I will take care of it when I am back. If you do not want to review it, or don't have time, John said to talk with him and he will find someone else. Thanks!
            Hide
            Permalink
            rearmstr Bob Armstrong added a comment -

            I am happy to review it and merge it.

            Show
            rearmstr Bob Armstrong added a comment - I am happy to review it and merge it.
            Hide
            Permalink
            rearmstr Bob Armstrong added a comment -

            Review looks fine. I made one minor edit and have merged the files.

            Show
            rearmstr Bob Armstrong added a comment - Review looks fine. I made one minor edit and have merged the files.

              People

              • Assignee:
                nlust Nate Lust
                Reporter:
                lauren Lauren MacArthur
                Reviewers:
                Bob Armstrong
                Watchers:
                Bob Armstrong, Jim Bosch, John Swinbank, Lauren MacArthur, Nate Lust, Nicolas Chotard
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel