Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4220

Convert copyright/license statements to one-liners for RFC-45

    Details

      Description

      Refactor how we manage copyright and license information in stack repositories

      1. Identify a list of packages to process
      2. build and test an automated system of
      • adding a global COPYRIGHT to each repo. Content will be “Copyright YYYY-YYYY The LSST DM Developers”. Years will be determined by git history.
      • adding a GPLv3 license file to each repo.
      • changing the boilerplate in all files to say "See the COPYRIGHT and LICENSE files in the top-level directory of this package for notices and licensing terms.” Use https://gist.github.com/ktlim/fdaea18ab3d39afdfa8e
      • automatically branch, commit, merge and push

      And deploy this automated system.

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            It's not a huge deal, but I think my original replacement script is somewhat more efficient because it only does regexp matches until the "see" line is found; the entire rest of the file is just copied verbatim. I think you're matching every line against the comment regexp and then doing tests on every content-containing comment thereafter. Is that just about replacing "#<sp>" with "#"?

            Show
            ktl Kian-Tat Lim added a comment - It's not a huge deal, but I think my original replacement script is somewhat more efficient because it only does regexp matches until the "see" line is found; the entire rest of the file is just copied verbatim. I think you're matching every line against the comment regexp and then doing tests on every content-containing comment thereafter. Is that just about replacing "#<sp>" with "#"?
            Hide
            jsick Jonathan Sick added a comment -

            Hold on, I incorrectly implemented C++ comment conversion. Will correct.

            Show
            jsick Jonathan Sick added a comment - Hold on, I incorrectly implemented C++ comment conversion. Will correct.
            Hide
            jsick Jonathan Sick added a comment -

            C++ migration works now!

            And Kian-Tat Lim, I get that the code is a bit inefficient. As you mention, my implementation of the replacement algorithm does have the nice feature of killing the extra space after a # in the Python license blocks. For a run-once utility that has a bit of extra functionality for a bit worse runtime performance, I consider this a fair tradeoff

            Show
            jsick Jonathan Sick added a comment - C++ migration works now! And Kian-Tat Lim , I get that the code is a bit inefficient. As you mention, my implementation of the replacement algorithm does have the nice feature of killing the extra space after a # in the Python license blocks. For a run-once utility that has a bit of extra functionality for a bit worse runtime performance, I consider this a fair tradeoff
            Hide
            ktl Kian-Tat Lim added a comment -

            I actually like the consistency of having "#<sp>" empty comment lines in Python. But I'm not wedded to it, and I guess it's not PEP8 compliant.

            Show
            ktl Kian-Tat Lim added a comment - I actually like the consistency of having "#<sp>" empty comment lines in Python. But I'm not wedded to it, and I guess it's not PEP8 compliant.
            Hide
            jsick Jonathan Sick added a comment -

            PR merged by Frossie Economou

            Show
            jsick Jonathan Sick added a comment - PR merged by Frossie Economou

              People

              • Assignee:
                jsick Jonathan Sick
                Reporter:
                jsick Jonathan Sick
                Reviewers:
                Frossie Economou
                Watchers:
                Frossie Economou, Jonathan Sick, Kian-Tat Lim, Michael Wood-Vasey, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel