Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4223

IsrTask calls removeFringe in FringeTask but the method does not exist

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None

      Description

      The method removeFringe of FringeTask is called in IsrTask but there is no removeFringe.

      Not sure if removeFringe was meant to be a place holder

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-4230 Port HSC-1355: Improved fringe subtraction

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Yusra AlSayyad would you might reviewing my changes (3 lines only) at branch u/hfc/DM-4223?

            These seem related to changes from DM-1299.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Yusra AlSayyad would you might reviewing my changes (3 lines only) at branch u/hfc/ DM-4223 ? These seem related to changes from DM-1299 .
            Hide
            Permalink
            price Paul Price added a comment -

            While you're looking at fringes, may I also suggest pulling over HSC-1355 (Fringe subtraction gets wrong solution) from github.com/HyperSuprime-Cam/ip_isr ?

            Show
            price Paul Price added a comment - While you're looking at fringes, may I also suggest pulling over HSC-1355 (Fringe subtraction gets wrong solution) from github.com/HyperSuprime-Cam/ip_isr ?
            Hide
            Permalink
            price Paul Price added a comment -

            Hsin-Fang Chiang forgot to put this into "In Review".

            Show
            price Paul Price added a comment - Hsin-Fang Chiang forgot to put this into "In Review".
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Hsin-Fang Chiang OK to merge.

            Show
            yusra Yusra AlSayyad added a comment - Hsin-Fang Chiang OK to merge.
            Hide
            Permalink
            hchiang2 Hsin-Fang Chiang added a comment -

            Thank you for the review!

            Changes are merged to master.

            Pulling over new edits from HSC is at DM-4230.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Thank you for the review! Changes are merged to master. Pulling over new edits from HSC is at DM-4230 .

              People

              Assignee:
              hchiang2 Hsin-Fang Chiang
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Hsin-Fang Chiang, Paul Price, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.