Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4232

Variance is set after dark subtraction

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None

      Description

      In the default IsrTask, the variance is currently set after dark subtraction. This means that photon noise from the dark is not included in the variance plane, which is incorrect. The variance should be set after bias subtraction and before dark subtraction.

      Hsin-Fang Chiang also points out (DM-4191) that the AssembleCcdTask with default parameters requires amplifier images with variance planes, even though the variance cannot be set properly until after full-frame bias subtraction. I believe that AssembleCcdTask only requires a variance plane in the amp images because it does an "effective gain" calculation, but I suggest that this isn't very useful (an approximation of an approximation, and you're never going to use that information anyway because it's embedded in the variance plane with better fidelity). I therefore suggest that this effective gain calculation be stripped out and that AssembleCcdTask not require variance planes.

        Attachments

          Issue Links

            Activity

            price Paul Price created issue -
            krughoff Simon Krughoff made changes -
            Field Original Value New Value
            Epic Link DM-3878 [ 20173 ]
            krughoff Simon Krughoff made changes -
            Component/s ip_isr [ 10730 ]
            krughoff Simon Krughoff made changes -
            Component/s ip_isr [ 10730 ]
            krughoff Simon Krughoff made changes -
            Story Points 5
            jbecla Jacek Becla made changes -
            Team Alert Production [ 10300 ]
            mrawls Meredith Rawls made changes -
            Watchers Hsin-Fang Chiang, Paul Price, Russell Owen [ Hsin-Fang Chiang, Paul Price, Russell Owen ] Hsin-Fang Chiang, Meredith Rawls, Paul Price, Russell Owen [ Hsin-Fang Chiang, Meredith Rawls, Paul Price, Russell Owen ]
            krughoff Simon Krughoff made changes -
            Reviewers Paul Price [ price ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            price Paul Price made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            krughoff Simon Krughoff made changes -
            Link This issue is triggered by RFC-282 [ RFC-282 ]
            krughoff Simon Krughoff made changes -
            Reviewers Paul Price [ price ] Hsin-Fang Chiang [ hchiang2 ]
            Status Reviewed [ 10101 ] In Review [ 10004 ]
            hchiang2 Hsin-Fang Chiang made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            krughoff Simon Krughoff made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              krughoff Simon Krughoff
              Reporter:
              price Paul Price
              Reviewers:
              Hsin-Fang Chiang
              Watchers:
              Hsin-Fang Chiang, Lauren MacArthur, Meredith Rawls, Paul Price, Robert Lupton, Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.