Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-4234

HSC backport: Jacobian and focalplane algorithms

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Sprint:
      Science Pipelines DM-W16-3, Science Pipelines DM-W16-4, Science Pipelines DM-W16-5
    • Team:
      Data Release Production

      Description

      Add algorithms to compute the Jacobian correction for each object (calculable from the Wcs, but sometimes convenient) and record the focal plane coordinates (instead of CCD coordinates) for sources (useful for plotting).

      The standalone HSC commits to be cherry-picked are:

      Jacobian
      meas_algorithms
      May 3, 2013
      Jacobian: add Algorithm to compute the Jacobian.
      May 24, 2013
      Jacobian: fix up some cut/paste oversights.
      May 28, 2013
      Jacobian: fix calculation

      obs_subaru
      May 3, 2013
      config: enable jacobian calculation in processCcd
      May 6, 2013
      config: set pixelScale for jacobian correction

      focalplane
      meas_algorithms
      May 24, 2013
      add algorithm to calculate position on the focal plane
      May 25, 2013
      fix up building of focalplane algorithm
      Nov 21, 2014
      Adapt to removal of Point<float> from afw::table.

      obs_subaru
      May 24, 2013
      config: activate focalplane algorithm

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment - - edited

            I'll start looking at the code shortly. In the meantime, Nate Lust, could you please explain the plot above? It's nice and colourful, but it's not obvious that it demonstrates these plugins do the correct thing. Have you checked that you get the same (or very similar) numbers running the same data through the equivalent code on HSC?

            Show
            swinbank John Swinbank added a comment - - edited I'll start looking at the code shortly. In the meantime, Nate Lust , could you please explain the plot above? It's nice and colourful, but it's not obvious that it demonstrates these plugins do the correct thing. Have you checked that you get the same (or very similar) numbers running the same data through the equivalent code on HSC?
            Hide
            swinbank John Swinbank added a comment -

            Review comments on GitHub. Quite a few relatively minor improvements; the most notable is that the Jacobian plugin needs some proper documentation explaining what it actually does.

            I agree that the pretty coloured plot is not implausible, but I'd still like you to expand on exactly how it demonstrates that these plugins are working – have you checked that the change in the output of the Jacobian plugin over the focal plane matches what you physically expect and have measured in the HSC stack?

            Show
            swinbank John Swinbank added a comment - Review comments on GitHub . Quite a few relatively minor improvements; the most notable is that the Jacobian plugin needs some proper documentation explaining what it actually does. I agree that the pretty coloured plot is not implausible, but I'd still like you to expand on exactly how it demonstrates that these plugins are working – have you checked that the change in the output of the Jacobian plugin over the focal plane matches what you physically expect and have measured in the HSC stack?
            Hide
            nlust Nate Lust added a comment -

            The plot above demonstrates that the focal plan plugin is able to calculate focal plan coordinates, as shown by the round shape, and the division for each CCD. The value of the Jacobian is what you would expect for a Jacobian calculated across the focal plane using the center as the point of approximation. That is to say the Jacobian should be close to one near the center, and decrease toward the edges and the approximation becomes a bit poorer. Additionally I have checked the values of the catalog against those generated with the HSC stack over the same dataIds, and they are very close to each other, differing only at the magnitude expected due to differences in the pipeline.

            Show
            nlust Nate Lust added a comment - The plot above demonstrates that the focal plan plugin is able to calculate focal plan coordinates, as shown by the round shape, and the division for each CCD. The value of the Jacobian is what you would expect for a Jacobian calculated across the focal plane using the center as the point of approximation. That is to say the Jacobian should be close to one near the center, and decrease toward the edges and the approximation becomes a bit poorer. Additionally I have checked the values of the catalog against those generated with the HSC stack over the same dataIds, and they are very close to each other, differing only at the magnitude expected due to differences in the pipeline.
            Hide
            nlust Nate Lust added a comment -

            merged to master

            Show
            nlust Nate Lust added a comment - merged to master
            Hide
            swinbank John Swinbank added a comment -
            Show
            swinbank John Swinbank added a comment - Release notes updated .

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              John Swinbank
              Watchers:
              John Swinbank, Lauren MacArthur, Nate Lust, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.