Thanks. It looks like some of my comments on the (revised) test suite got overlooked though – they were made before you renamed the file, so they now come up as "comments on an outdated diff" even though the underlying code hasn't been adjusted. Specifically, could you please take another look at the following:

• https://github.com/lsst/meas_base/pull/28#discussion_r47902866
• https://github.com/lsst/meas_base/pull/28#discussion_r47903109
• https://github.com/lsst/meas_base/pull/28#discussion_r47903110
• https://github.com/lsst/meas_base/pull/28#discussion_r47903113
• https://github.com/lsst/meas_base/pull/28#discussion_r47903268
• https://github.com/lsst/meas_base/pull/28#discussion_r47903507

I'd also like to draw your attention to my question about the figure you've attached to this issue.

Everything else looks fine.

I have addressed the above comments, take a look whenever you get a chance

You've still not answered my question about the figure!

Other than that, I think this is basically fine. I added two tiny comments on the PR (please use @param when documenting function parameters, and I think your displayPlot() function is obsolete). In addition, if you are forced to use NumPy rather than afw.math due to DM-4804, please add a comment to say so.

The history obviously needs cleaning up, but other than that you're good to go.

Ga! I think about the question every time I start reading over your responses and forget it by the end. The plot above does show that all the numbers are the right order of magnitude and vary in a way that would be expected across the focal plane. Additionally I looked at the actual numerical output in table form and verified that the numbers we are getting with this plugin and the values produced by the HSC stack are very very close to each other.

Has been merged. Release notes updated.