[DM-4238] Fix integer casting error in numpy version 1.10 in obs subaru - Jira

Nate Lust created issue - 02/Nov/15 3:30 PM

Nate Lust made changes - 02/Nov/15 3:35 PM

Field	Original Value	New Value
Status	To Do [ 10001 ]	In Progress [ 3 ]

Nate Lust made changes - 02/Nov/15 3:36 PM

Reviewers		Paul Price [ price ]
Status	In Progress [ 3 ]	In Review [ 10004 ]

Hide

Permalink

Nate Lust added a comment - 02/Nov/15 3:45 PM - edited

In case anyone has a similar error, here is the traceback that prompted this ticket. The solution involves explicitly casting the numpy array to dtype int.

Traceback (most recent call last):

  File "/tigress/HSC/users/nate/repos/pipe_base/python/lsst/pipe/base/cmdLineTask.py", line 321, in __call__

    result = task.run(dataRef, **kwargs)

  File "/tigress/HSC/users/nate/repos/pipe_base/python/lsst/pipe/base/timer.py", line 118, in wrapper

    res = func(self, *args, **keyArgs)

  File "/tigress/HSC/users/nate/lsstsw/stack/Linux64/pipe_tasks/11.0-14-ga314014/python/lsst/pipe/tasks/processCcd.py", line 132, in run

    postIsrExposure = self.setPostIsrExposure(sensorRef)

  File "/tigress/HSC/users/nate/lsstsw/stack/Linux64/pipe_tasks/11.0-14-ga314014/python/lsst/pipe/tasks/processCcd.py", line 111, in setPostIsrExposure

    postIsrExposure = self.isr.runDataRef(sensorRef).exposure

  File "/tigress/HSC/users/nate/repos/obs_subaru/python/lsst/obs/subaru/isr.py", line 228, in runDataRef

    self.crosstalk.run(ccdExposure)

  File "/tigress/HSC/users/nate/repos/obs_subaru/python/lsst/obs/subaru/crosstalk.py", line 82, in run

    self.config.crosstalkMaskPlane)

  File "/tigress/HSC/users/nate/repos/obs_subaru/python/lsst/obs/subaru/crosstalk.py", line 270, in subtractXTalk

    np_msk[setThese][:] &= ~crosstalk

TypeError: ufunc 'bitwise_and' output (typecode 'i') could not be coerced to provided output parameter (typecode 'H') according to the casting rule ''same_kind''

Show

Nate Lust added a comment - 02/Nov/15 3:45 PM - edited In case anyone has a similar error, here is the traceback that prompted this ticket. The solution involves explicitly casting the numpy array to dtype int . Traceback (most recent call last): File "/tigress/HSC/users/nate/repos/pipe_base/python/lsst/pipe/base/cmdLineTask.py", line 321, in __call__ result = task.run(dataRef, **kwargs) File "/tigress/HSC/users/nate/repos/pipe_base/python/lsst/pipe/base/timer.py", line 118, in wrapper res = func(self, *args, **keyArgs) File "/tigress/HSC/users/nate/lsstsw/stack/Linux64/pipe_tasks/11.0-14-ga314014/python/lsst/pipe/tasks/processCcd.py", line 132, in run postIsrExposure = self.setPostIsrExposure(sensorRef) File "/tigress/HSC/users/nate/lsstsw/stack/Linux64/pipe_tasks/11.0-14-ga314014/python/lsst/pipe/tasks/processCcd.py", line 111, in setPostIsrExposure postIsrExposure = self.isr.runDataRef(sensorRef).exposure File "/tigress/HSC/users/nate/repos/obs_subaru/python/lsst/obs/subaru/isr.py", line 228, in runDataRef self.crosstalk.run(ccdExposure) File "/tigress/HSC/users/nate/repos/obs_subaru/python/lsst/obs/subaru/crosstalk.py", line 82, in run self.config.crosstalkMaskPlane) File "/tigress/HSC/users/nate/repos/obs_subaru/python/lsst/obs/subaru/crosstalk.py", line 270, in subtractXTalk np_msk[setThese][:] &= ~crosstalk TypeError: ufunc 'bitwise_and' output (typecode 'i') could not be coerced to provided output parameter (typecode 'H') according to the casting rule ''same_kind''

Hide

Permalink

Paul Price added a comment - 02/Nov/15 3:50 PM

Does the astype('int') produce a copy or a view? If a copy, then the modification being made in the next line will be lost.

I suggest adding an explanation in the commit message pointing to whatever changed in numpy.

Show

Paul Price added a comment - 02/Nov/15 3:50 PM Does the astype('int') produce a copy or a view? If a copy, then the modification being made in the next line will be lost. I suggest adding an explanation in the commit message pointing to whatever changed in numpy.

Paul Price made changes - 02/Nov/15 3:50 PM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Hide

Permalink

Nate Lust added a comment - 03/Nov/15 9:17 AM - edited

You are right to check. I seem to remember astype returning a view, but it seems to return a copy now (unless it can be sure of compatible cast I think). I updated the solution to not cast the array, but cast the integer being compared.

Show

Nate Lust added a comment - 03/Nov/15 9:17 AM - edited You are right to check. I seem to remember astype returning a view, but it seems to return a copy now (unless it can be sure of compatible cast I think). I updated the solution to not cast the array, but cast the integer being compared.

Nate Lust made changes - 03/Nov/15 9:19 AM

Story Points

0.25

0.5

Tim Jenness made changes - 03/Nov/15 9:50 AM

Link

This issue relates to ~~DM-4063~~ [ ~~DM-4063~~ ]

Hide

Permalink

Tim Jenness added a comment - 03/Nov/15 9:50 AM

I've linked this ticket to ~~DM-4063~~, which covers the same ground.

Show

Tim Jenness added a comment - 03/Nov/15 9:50 AM I've linked this ticket to DM-4063 , which covers the same ground.

Nate Lust made changes - 03/Nov/15 10:12 AM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

John Swinbank made changes - 04/Nov/15 6:19 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 04/Nov/15 6:20 AM

Epic Link

~~DM-3586~~ [ 19683 ]

John Swinbank made changes - 04/Nov/15 6:20 AM

Sprint		Science Pipelines DM-W16-3 [ 182 ]
Team		Data Release Production [ 10301 ]

Hide

Permalink

Tim Jenness added a comment - 04/Nov/15 8:27 AM

This highlights why it would be good to have the obs_ packages in CI – we fixed all the casting problems we found from CI in ~~DM-4063~~.

Show

Tim Jenness added a comment - 04/Nov/15 8:27 AM This highlights why it would be good to have the obs_ packages in CI – we fixed all the casting problems we found from CI in DM-4063 .

Nate Lust made changes - 04/Nov/15 9:04 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 04/Nov/15 9:05 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 04/Nov/15 9:09 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 04/Nov/15 9:42 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 04/Nov/15 9:44 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 04/Nov/15 9:49 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Hide

Permalink

Paul Price added a comment - 04/Nov/15 9:54 AM

We delivered a CI package to the SQuARE team for integration into CI in ~~DM-3663~~.

Show

Paul Price added a comment - 04/Nov/15 9:54 AM We delivered a CI package to the SQuARE team for integration into CI in DM-3663 .

John Swinbank made changes - 04/Nov/15 10:42 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 04/Nov/15 10:44 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 13/Nov/15 11:59 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 16/Nov/15 5:03 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 16/Nov/15 3:33 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 16/Nov/15 4:10 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 17/Nov/15 8:31 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Vishal Kasliwal [X] (Inactive) made changes - 25/Nov/15 2:15 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 30/Nov/15 7:48 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 01/Dec/15 8:29 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 01/Dec/15 9:56 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 01/Dec/15 10:02 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 01/Dec/15 10:36 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 01/Dec/15 12:50 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 01/Dec/15 12:51 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 01/Dec/15 1:04 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 01/Dec/15 1:30 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 01/Dec/15 1:36 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 02/Dec/15 9:34 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 02/Dec/15 11:02 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 04/Dec/15 9:12 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 07/Dec/15 12:53 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 07/Dec/15 3:25 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 07/Dec/15 3:27 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 09/Dec/15 5:40 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 21/Dec/15 10:26 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Russell Owen made changes - 21/Dec/15 11:48 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Russell Owen made changes - 21/Dec/15 11:50 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Russell Owen made changes - 21/Dec/15 11:52 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 23/Dec/15 3:34 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 04/Jan/16 4:26 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 11/Jan/16 3:52 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 12/Jan/16 6:57 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 14/Jan/16 6:57 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 19/Jan/16 8:34 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 19/Jan/16 8:37 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 19/Jan/16 9:00 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 20/Jan/16 12:25 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 20/Jan/16 12:45 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 20/Jan/16 12:53 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 20/Jan/16 12:58 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 26/Jan/16 6:26 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 28/Jan/16 10:50 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 28/Jan/16 10:54 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 29/Jan/16 8:44 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Jim Bosch made changes - 01/Feb/16 9:09 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Paul Price made changes - 01/Feb/16 9:55 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 01/Feb/16 11:52 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 01/Feb/16 11:58 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 08/Feb/16 6:22 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 08/Feb/16 6:28 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 08/Feb/16 6:38 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 08/Feb/16 6:44 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 08/Feb/16 6:50 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 08/Feb/16 6:52 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 08/Feb/16 6:52 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 08/Feb/16 3:18 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 10/Feb/16 10:46 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 15/Feb/16 5:54 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 15/Feb/16 5:56 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 15/Feb/16 5:59 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 15/Feb/16 7:46 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 01/Mar/16 7:33 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 04/Mar/16 8:38 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 04/Mar/16 11:58 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 04/Mar/16 5:33 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Bob Armstrong made changes - 09/Mar/16 11:17 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Russell Owen made changes - 09/Mar/16 3:32 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 15/Mar/16 5:44 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 16/Mar/16 11:53 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 16/Mar/16 1:50 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 01/Apr/16 11:47 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 01/Apr/16 12:15 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 01/Apr/16 12:22 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 01/Apr/16 12:31 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 06/Apr/16 5:44 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 06/Apr/16 5:47 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 07/Apr/16 3:49 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Jim Bosch made changes - 07/Apr/16 12:00 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 11/Apr/16 5:55 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 11/Apr/16 5:57 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 11/Apr/16 6:00 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 11/Apr/16 10:02 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 11/Apr/16 2:01 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 11/Apr/16 2:03 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 11/Apr/16 2:26 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 12/Apr/16 5:57 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 12/Apr/16 6:01 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 12/Apr/16 6:05 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 12/Apr/16 6:48 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 26/Apr/16 7:29 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 26/Apr/16 7:30 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 02/May/16 12:32 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 02/May/16 12:40 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 02/May/16 12:55 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Paul Price made changes - 02/May/16 1:05 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Pim Schellart [X] (Inactive) made changes - 05/May/16 2:58 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 10/May/16 2:22 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Lauren MacArthur made changes - 12/May/16 5:20 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 13/May/16 12:22 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 13/May/16 12:40 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Nate Lust made changes - 17/May/16 11:49 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Jim Bosch made changes - 17/May/16 12:09 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Jim Bosch made changes - 18/May/16 12:07 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 18/May/16 5:39 PM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 31/May/16 10:41 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 06/Jun/16 8:45 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 06/Jun/16 9:52 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 06/Jun/16 9:55 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

John Swinbank made changes - 06/Jun/16 10:10 AM

Remote Link

This issue links to "Page (Confluence)" [ 13109 ]

Data Management

Fix integer casting error in numpy version 1.10 in obs subaru

Details

Description

Attachments

Issue Links

Activity

People

Dates