Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_isr, obs_lsstSim
-
Labels:None
-
Story Points:8
-
Epic Link:
-
Team:Data Facility
Description
The fringe subtraction is not necessarily performed if doFringe is True. It is only if the filter of the raw exposure is listed in config fringe.filters.
Fringe data should not be read unless the filter is indicated. There are likely no such filter data and it would cause runtime errors.
Attachments
Issue Links
- relates to
-
DM-4230 Port HSC-1355: Improved fringe subtraction
- Done
That is fair. From an users perspective, I can imagine thinking "I already said config.doFringe=False. Why do I also have to say getFringeData=False?" I'm thinking that your initial commit that passed the whole ccdExposure may be better than getFringeData without a default (especially if it makes your edits to the obs_ packages cleaner). I guess it comes down to the lesser of two evils: require the users to pass an exposure just to get some data from the butler or ask the users to decide whether to read in the fringe data.
Hopefully, New Butler will allow us to write a def checkFilters(self, sensorRef). Seems like it should be possible if the butler can already find the flats/fringes of the correct filter based only on the dataId.